-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with float field terms query #12499
Conversation
2ea445d
to
b0d6fa5
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
f984b23
to
5c58e75
Compare
Compatibility status:Checks if related components are compatible with change cc173b1 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 2ea445d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
❌ Gradle check result for 5c58e75: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b0d6fa5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12499 +/- ##
============================================
+ Coverage 71.37% 71.40% +0.02%
- Complexity 59891 59914 +23
============================================
Files 4972 4972
Lines 281783 281797 +14
Branches 40910 40913 +3
============================================
+ Hits 201136 201224 +88
+ Misses 63977 63887 -90
- Partials 16670 16686 +16 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for cc173b1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12499-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a22f284a19e986d7e2732762554e6e2fedbd25c
# Push it to GitHub
git push --set-upstream origin backport/backport-12499-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@harshavamsi could you please backport to 2.x manually? thank you |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 8a22f28)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 8a22f28)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 8a22f28)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 8a22f28)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Aman Khare <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adds a failing integ test for terms query on a
float
field. This change fixes the use ofFloatField
back toFloatPoint
. This was an accidental change that went in as part of #11209.Related Issues
Resolves #12432
Check List
New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.