Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute get field mapping test #12422

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

andrross
Copy link
Member

This test was muted due to an intermediate state during type removal. It now passes per my local testing.

Related Issues

Resolves #2440

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Compatibility status:

Checks if related components are compatible with change ade3496

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 9fedf95: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: opensearch-project#2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the unmute-field-mapping-test branch from 9fedf95 to ade3496 Compare February 21, 2024 23:07
Copy link
Contributor

❕ Gradle check result for ade3496: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.classMethod
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e97bee8) 71.47% compared to head (ade3496) 71.39%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12422      +/-   ##
============================================
- Coverage     71.47%   71.39%   -0.08%     
+ Complexity    59938    59841      -97     
============================================
  Files          4972     4972              
  Lines        281770   281774       +4     
  Branches      40910    40910              
============================================
- Hits         201385   201173     -212     
- Misses        63710    63880     +170     
- Partials      16675    16721      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit a50d1f6 into opensearch-project:main Feb 22, 2024
30 of 31 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: #2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit a50d1f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Feb 22, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: #2440 (comment)


(cherry picked from commit a50d1f6)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross deleted the unmute-field-mapping-test branch February 27, 2024 22:05
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: opensearch-project#2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: opensearch-project#2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Aman Khare <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: opensearch-project#2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
This test was muted due to an [intermediate state][1] during type
removal. It now passes per my local testing.

[1]: opensearch-project#2440 (comment)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flaky test failure - v1.2.5#mixedClusterTest - yaml rest test - indices.get_field_mapping
3 participants