-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Searchable Snapshot] Fix bug of Searchable Snapshot Dependency on repository chunk_size #12277
[Searchable Snapshot] Fix bug of Searchable Snapshot Dependency on repository chunk_size #12277
Conversation
…ile. Signed-off-by: Rishikesh1159 <[email protected]>
Compatibility status:Checks if related components are compatible with change f5ecacb Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 1b82213: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/remote/utils/TransferManager.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/snapshots/SearchableSnapshotIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh1159 <[email protected]>
|
...er/src/main/java/org/opensearch/index/store/remote/file/OnDemandBlockSnapshotIndexInput.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/utils/TransferManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
…/OpenSearch into fix-chunk_size-bug
❌ Gradle check result for 40f47e5: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 40f47e5: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
...c/test/java/org/opensearch/index/store/remote/file/OnDemandBlockSnapshotIndexInputTests.java
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for f1a27f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3125b94
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12277-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3125b948029609f354d3153f8ca6391638daefc7
# Push it to GitHub
git push --set-upstream origin backport/backport-12277-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@Rishikesh1159 Looks like a backport was missed, causing the conflict on this PR's backport. Can you create the manual backport after #12485 is merged? |
…pository chunk_size (#12277) * implement logic of fetching blocks from multiple chunks of snapshot file. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor and address comments. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Address comments of using a different data structure to fetch blob parts. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary code. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor outputstream usage. Signed-off-by: Rishikesh1159 <[email protected]> * refactor blobpart logic into a separate method and add unit tests. Signed-off-by: Rishikesh1159 <[email protected]> * Add new unit tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 3125b94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Rishikesh1159 / @andrross |
…pository chunk_size (#12277) (#12486) * implement logic of fetching blocks from multiple chunks of snapshot file. * Refactor and address comments. * apply spotless check * Address comments of using a different data structure to fetch blob parts. * remove unnecessary code. * Refactor outputstream usage. * refactor blobpart logic into a separate method and add unit tests. * Add new unit tests. --------- (cherry picked from commit 3125b94) Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pository chunk_size (opensearch-project#12277) * implement logic of fetching blocks from multiple chunks of snapshot file. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor and address comments. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Address comments of using a different data structure to fetch blob parts. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary code. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor outputstream usage. Signed-off-by: Rishikesh1159 <[email protected]> * refactor blobpart logic into a separate method and add unit tests. Signed-off-by: Rishikesh1159 <[email protected]> * Add new unit tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…pository chunk_size (opensearch-project#12277) * implement logic of fetching blocks from multiple chunks of snapshot file. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor and address comments. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Address comments of using a different data structure to fetch blob parts. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary code. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor outputstream usage. Signed-off-by: Rishikesh1159 <[email protected]> * refactor blobpart logic into a separate method and add unit tests. Signed-off-by: Rishikesh1159 <[email protected]> * Add new unit tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Aman Khare <[email protected]>
…pository chunk_size (opensearch-project#12277) * implement logic of fetching blocks from multiple chunks of snapshot file. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor and address comments. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Address comments of using a different data structure to fetch blob parts. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary code. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor outputstream usage. Signed-off-by: Rishikesh1159 <[email protected]> * refactor blobpart logic into a separate method and add unit tests. Signed-off-by: Rishikesh1159 <[email protected]> * Add new unit tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…pository chunk_size (opensearch-project#12277) * implement logic of fetching blocks from multiple chunks of snapshot file. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor and address comments. Signed-off-by: Rishikesh1159 <[email protected]> * apply spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Address comments of using a different data structure to fetch blob parts. Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary code. Signed-off-by: Rishikesh1159 <[email protected]> * Refactor outputstream usage. Signed-off-by: Rishikesh1159 <[email protected]> * refactor blobpart logic into a separate method and add unit tests. Signed-off-by: Rishikesh1159 <[email protected]> * Add new unit tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR is still in draft version and purpose of this PR is to get some feedback on the approach for resolving the issue.
Once approach is finalized I will put this PR out of draft version and refactor with adding some tests.
The PR implements logic of fetching blocks from multiple chunks of snapshot file.
Related Issues
Resolves #9676
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.