Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Check phase name before SearchRequestOperationsListener onPhase… #12094

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[Bug] Check phase name before SearchRequestOperationsListener onPhase… #12094

merged 1 commit into from
Jan 31, 2024

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Jan 30, 2024 •
edited
Loading

…Start (#12094)

Signed-off-by: David Zane [email protected]
(cherry picked from commit fb2c5f2)

Description

2.x Backport of #12035

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dzane17 added a commit to dzane17/OpenSearch that referenced this pull request Jan 30, 2024
@dzane17
[Bug] Check phase name before SearchRequestOperationsListener onPhase…
60eda16 
…Start (opensearch-project#12094)

Signed-off-by: David Zane <[email protected]>
(cherry picked from commit fb2c5f2)
@dzane17 dzane17 force-pushed the backport/backport-12035-to-2.x branch from 466fa72 to 60eda16 Compare January 30, 2024 21:22
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 466fa72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 60eda16: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 5548d19

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

dzane17 added a commit to dzane17/OpenSearch that referenced this pull request Jan 30, 2024
@dzane17
[Bug] Check phase name before SearchRequestOperationsListener onPhase…
49f4846 
…Start (opensearch-project#12094)

Signed-off-by: David Zane <[email protected]>
(cherry picked from commit fb2c5f2)
@dzane17 dzane17 force-pushed the backport/backport-12035-to-2.x branch from 60eda16 to 49f4846 Compare January 30, 2024 21:54
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 49f4846:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 49f4846: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dzane17 dzane17 force-pushed the backport/backport-12035-to-2.x branch from 49f4846 to 5548d19 Compare January 31, 2024 02:25
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 5548d19: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0330e08) 71.09% compared to head (5548d19) 71.08%.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #12094      +/-   ##
============================================
- Coverage     71.09%   71.08%   -0.01%     
+ Complexity    59425    59401      -24     
============================================
  Files          4892     4892              
  Lines        280005   280012       +7     
  Branches      41073    41075       +2     
============================================
- Hits         199070   199059      -11     
+ Misses        64060    64048      -12     
- Partials      16875    16905      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzane17
Copy link
Contributor Author

dzane17 commented Jan 31, 2024

❌ Gradle check result for 49f4846: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

testPrimaryRelocationWhileIndexing is flaky #9191

@msfroh msfroh merged commit 3a951e5 into opensearch-project:2.x Jan 31, 2024
29 checks passed
@dzane17 dzane17 deleted the backport/backport-12035-to-2.x branch March 13, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzane17 @msfroh