Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test CardinalityWithRequestBreakerIT.testRequestBreaker after lucene 99 upgrade #11841

Merged

Conversation

neetikasinghal
Copy link
Contributor

@neetikasinghal neetikasinghal commented Jan 10, 2024

Description

Enabling the test as the memory leak wouldn't happen after lucene 99 upgrade as explained here

Validated that the required lucene change is present and ran the test with relevant seed for 500 times to ensure successful runs.

Related Issues

Resolves #10154

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@neetikasinghal
Copy link
Contributor Author

@reta / @sohami this is just one line change, ready to be merged once the workflow turns green.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 46e3313

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 46e3313: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 10, 2024

❌ Gradle check result for 46e3313: FAILURE

#11547

Copy link
Contributor

❕ Gradle check result for 46e3313: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feeb595) 71.36% compared to head (46e3313) 71.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11841      +/-   ##
============================================
+ Coverage     71.36%   71.37%   +0.01%     
- Complexity    59304    59326      +22     
============================================
  Files          4919     4919              
  Lines        278912   278912              
  Branches      40543    40543              
============================================
+ Hits         199052   199083      +31     
+ Misses        63337    63263      -74     
- Partials      16523    16566      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit 10be2ef into opensearch-project:main Jan 10, 2024
78 of 136 checks passed
@kotwanikunal
Copy link
Member

@neetikasinghal Do you want to backport it to 2.x as well?

@neetikasinghal neetikasinghal added the backport 2.x Backport to 2.x branch label Jan 10, 2024
@neetikasinghal
Copy link
Contributor Author

neetikasinghal commented Jan 10, 2024

@neetikasinghal Do you want to backport it to 2.x as well?

@kotwanikunal thanks for merging, yes I have just added the label for it.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2024
…lucene 99 upgrade (#11841)

Signed-off-by: Neetika Singhal <[email protected]>
(cherry picked from commit 10be2ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@neetikasinghal neetikasinghal deleted the flaky-cardi-final branch January 10, 2024 23:22
reta pushed a commit that referenced this pull request Jan 11, 2024
…lucene 99 upgrade (#11841) (#11845)

(cherry picked from commit 10be2ef)

Signed-off-by: Neetika Singhal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…lucene 99 upgrade (opensearch-project#11841)

Signed-off-by: Neetika Singhal <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flaky org.opensearch.search.aggregations.metrics.CardinalityWithRequestBreakerIT test
3 participants