-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky QueryProfilePhaseTests.testTerminateAfterEarlyTermination #11683
Fix flaky QueryProfilePhaseTests.testTerminateAfterEarlyTermination #11683
Conversation
Compatibility status:Checks if related components are compatible with change 3c00409 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for 88eb13d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11683 +/- ##
============================================
+ Coverage 71.35% 71.48% +0.12%
- Complexity 59201 59283 +82
============================================
Files 4906 4906
Lines 278198 278198
Branches 40422 40422
============================================
+ Hits 198520 198865 +345
+ Misses 63229 62834 -395
- Partials 16449 16499 +50 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ticheng Lin <[email protected]>
88eb13d
to
3c00409
Compare
❕ Gradle check result for 3c00409: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Known issue #9191 |
server/src/test/java/org/opensearch/search/query/QueryProfilePhaseTests.java
Show resolved
Hide resolved
Signed-off-by: Ticheng Lin <[email protected]> (cherry picked from commit bb3959d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit bb3959d) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
QueryProfilePhaseTests.testTerminateAfterEarlyTermination
is flaky not only in the concurrent search case but also in the non-concurrent search case. In cases where the test query returns some total hits, it is possible that thescore
breakdown timing for certain rewritten or sub-queries is still zero. Consequently, we need to update the assertion check accordingly.Additionally, in the concurrent search case, there is a particular scenario where some slices have zero
score
breakdown timing, while others have non-zeroscore
breakdown timing. In this case, themin_score
stat result will be expected zero. I ran the new changes1000+
times to make sure that they all passed.Related Issues
Resolves #11611
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.