[Backport 2.x] Add additional handling in SearchTemplateRequest when simulate is set to true #11646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… to true (#11591) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 863d453) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
cwperks
approved these changes
Dec 19, 2023
peternied
approved these changes
Dec 19, 2023
|
❌ Gradle check result for e090fec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@reta Could you help me to re-run the failing CI check on this PR? I don't have access to re-trigger it. Its impacted by a known flaky test. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11646 +/- ##
============================================
- Coverage 71.19% 71.03% -0.17%
+ Complexity 59363 59232 -131
============================================
Files 4883 4883
Lines 279308 279314 +6
Branches 40934 40934
============================================
- Hits 198860 198409 -451
- Misses 63637 64080 +443
- Partials 16811 16825 +14 ☔ View full report in Codecov by Sentry. |
cwperks
added a commit
to opensearch-project/security
that referenced
this pull request
Dec 21, 2023
) (#3872) Manual backport of #3689 to 2.x. CI will not pass until the companion core backport is merged: opensearch-project/OpenSearch#11646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 863d453 from #11591.