Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RAM Usage Calculation to precomputed block for IndexVersionValue #11587

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Dec 12, 2023

Description

Move RAM Usage to static pre-computed block #11586

Related Issues

Resolves #11586

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Indexing Indexing, Bulk Indexing and anything related to indexing Indexing:Performance labels Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Compatibility status:

Checks if related components are compatible with change 1e2b049

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 0b97de6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan changed the title Move RAM Usage to precomputed block Move RAM Usage Calculation to precomputed block Dec 12, 2023
@mgodwan mgodwan changed the title Move RAM Usage Calculation to precomputed block Move RAM Usage Calculation to precomputed block for IndexVersionValue Dec 12, 2023
@mgodwan mgodwan marked this pull request as ready for review December 12, 2023 10:47
Copy link
Contributor

❌ Gradle check result for 386fbae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a2ecbe2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgodwan. Lgtm!

Copy link
Contributor

✅ Gradle check result for 1e2b049: SUCCESS

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66d4e9e) 71.31% compared to head (1e2b049) 71.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11587      +/-   ##
============================================
+ Coverage     71.31%   71.44%   +0.13%     
- Complexity    59163    59186      +23     
============================================
  Files          4906     4906              
  Lines        278171   278172       +1     
  Branches      40420    40420              
============================================
+ Hits         198374   198748     +374     
+ Misses        63301    62931     -370     
+ Partials      16496    16493       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Dec 12, 2023

Thanks @mgodwan , the change looks very reasonable, the Translog.Location instance should have constant size indeed

@reta reta merged commit b5700b4 into opensearch-project:main Dec 12, 2023
29 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Dec 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 12, 2023
Signed-off-by: mgodwan <[email protected]>
(cherry picked from commit b5700b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11587-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5700b4317257e2b247d14de17636780819fba8d
# Push it to GitHub
git push --set-upstream origin backport/backport-11587-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11587-to-2.x.

@reta
Copy link
Collaborator

reta commented Dec 12, 2023

@mgodwan could you please backport to 2.x. manually? thank you not sure what is happening but backport was created #11590

reta pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit b5700b4)

Signed-off-by: mgodwan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Indexing:Performance Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] Reduce computation for RAM Bytes used for IndexVersionValue
4 participants