Add support for dependencies in plugin descriptor properties with semver range

[abseth-amzn]

Description

As a first step towards supporting semVer range of compatible versions for plugins, we are starting with support for specifying 'dependencies' for a plugin in its plugin-descriptor.properties file. The change currently supports specification of only one dependency (opensearch). Following notations are supported for specifying the compatible dependency version:

• dependencies={ opensearch: x.y.z }
• dependencies={ opensearch: =x.y.z }
• dependencies={ opensearch: ~x.y.z }
• dependencies={ opensearch: ^x.y.z }
  (specification of major, minor and patch version is required in above notations)

Related Issues

• Resolves [opensearch-plugin] Cannot install old patch version of plugins on newer opensearch builds  #1707

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 7e41183: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 18a80e1

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

[github-actions]

❌ Gradle check result for f44551f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 18a80e1: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[reta]

@abseth-amzn we still have DCO failures sadly for some commits, may need rebase + squash

[rursprung]

thanks, this should simplify upgrades greatly!
will this be cherry-picked to the 2.12 or at least the 2.x branch?

[abseth-amzn]

thanks, this should simplify upgrades greatly! will this be cherry-picked to the 2.12 or at least the 2.x branch?

Yes, working on backporting it to 2.x branch.

[abseth-amzn]

Backport PR for 2.x branch - #12271
BwC fix PR - #12273

[rursprung]

@saratvemulapalli: is there an example plugin where this is being used (e.g. opensearch-plugin-template-java would be a good place)?
how is this working with the gradle plugin (opensearchplugin, from org.opensearch.gradle:build-tools)?

[dblock]

@rursprung AFAIK no. If you are looking to a semi-production plugin to contribute an example to, may I volunteer https://github.com/dblock/opensearch-api? :)

[rursprung]

@rursprung AFAIK no. If you are looking to a semi-production plugin to contribute an example to, may I volunteer https://github.com/dblock/opensearch-api? :)

i wanted to contribute it to another plugin but i fail to see how it can be done with the gradle plugin - either i'm missing something or it's not possible yet with that one? 😕

[dblock]

@rursprung I don't think you're missing anything, probably not implemented

[rursprung]

i've raised #13187 to address this