Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sort] Sending missing values in comparator instead sending null #11196

Merged
merged 2 commits into from
Nov 16, 2023

Removing missing value outdated comments

9b0af16
Select commit
Loading
Failed to load commit list.
Merged

[Sort] Sending missing values in comparator instead sending null #11196

Removing missing value outdated comments
9b0af16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 14, 2023 in 0s

13.20% of diff hit (target 71.12%)

View this Pull Request on Codecov

13.20% of diff hit (target 71.12%)

Annotations

Check warning on line 48 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L48 

Added line #L48 was not covered by tests

Check warning on line 52 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L52 

Added line #L52 was not covered by tests

Check warning on line 55 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L55 

Added line #L55 was not covered by tests

Check warning on line 63 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L63 

Added line #L63 was not covered by tests

Check warning on line 65 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L65 

Added line #L65 was not covered by tests

Check warning on line 68 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L67-L68 

Added lines #L67 - L68 were not covered by tests

Check warning on line 70 in server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/fieldcomparator/HalfFloatValuesComparatorSource.java#L70 

Added line #L70 was not covered by tests

Check warning on line 31 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L30-L31 

Added lines #L30 - L31 were not covered by tests

Check warning on line 35 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L35 

Added line #L35 was not covered by tests

Check warning on line 42 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L40-L42 

Added lines #L40 - L42 were not covered by tests

Check warning on line 46 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L46 

Added line #L46 was not covered by tests

Check warning on line 51 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L51 

Added line #L51 was not covered by tests

Check warning on line 59 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L57-L59 

Added lines #L57 - L59 were not covered by tests

Check warning on line 63 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L63 

Added line #L63 was not covered by tests

Check warning on line 65 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L65 

Added line #L65 was not covered by tests

Check warning on line 73 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L71-L73 

Added lines #L71 - L73 were not covered by tests

Check warning on line 77 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L77 

Added line #L77 was not covered by tests

Check warning on line 82 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L82 

Added line #L82 was not covered by tests

Check warning on line 89 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L87-L89 

Added lines #L87 - L89 were not covered by tests

Check warning on line 93 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L93 

Added line #L93 was not covered by tests

Check warning on line 98 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L98 

Added line #L98 was not covered by tests

Check warning on line 104 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L103-L104 

Added lines #L103 - L104 were not covered by tests

Check warning on line 109 in server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java#L108-L109 

Added lines #L108 - L109 were not covered by tests
View more details on Codecov