Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky and failing test cases for concurrent search #11184

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

e-emoto
Copy link
Contributor

@e-emoto e-emoto commented Nov 13, 2023

Description

This makes use of the indexRandomForConcurrentSearch function, which creates more segments for concurrent search tests, in several test cases for their concurrent search use-cases. The following test suites are affected by this change:

  • RandomScoreFunctionIT.java
  • FetchSubPhasePluginIT.java
  • SearchWhileRelocatingIT.java

Related Issues

Resolves #11112
Resolves #11106

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Compatibility status:

Checks if related components are compatible with change 1708c9e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

✅ Gradle check result for b32a936: SUCCESS

            Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
Copy link
Contributor

✅ Gradle check result for 1708c9e: SUCCESS

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8077a26) 71.12% compared to head (1708c9e) 71.26%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11184      +/-   ##
============================================
+ Coverage     71.12%   71.26%   +0.13%     
- Complexity    58788    58849      +61     
============================================
  Files          4883     4883              
  Lines        277152   277152              
  Branches      40281    40281              
============================================
+ Hits         197134   197521     +387     
+ Misses        63545    63146     -399     
- Partials      16473    16485      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326
Copy link
Collaborator

jed326 commented Nov 14, 2023

@sohami @reta @andrross could you help review + merge this? Thanks!

@reta reta merged commit 39308bf into opensearch-project:main Nov 14, 2023
@jed326 jed326 added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Nov 14, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2023
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
(cherry picked from commit 39308bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326 pushed a commit to jed326/OpenSearch that referenced this pull request Nov 16, 2023
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
sohami pushed a commit that referenced this pull request Nov 17, 2023
* Add indexRandomForConcurrentSearch method to tests: (#11118)

* IndexStatsIT.java
* SearchTimeoutIT.java
* NaNSortingIT.java
* NestedIT.java
* RangeIT.java

Signed-off-by: Jay Deng <[email protected]>

* Add indexRandomForConcurrentSearch for tests: (#11181)

* MultiSearchIT.java
* SimpleNestedIT.java
* SearchPreferenceIT.java
* SimpleQueryStringIT.java
* ScriptQuerySearchIT.java

Signed-off-by: Jay Deng <[email protected]>

* Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212)

Signed-off-by: Ganesh Ramadurai <[email protected]>
Co-authored-by: Ganesh Ramadurai <[email protected]>

* Fix tests for concurrent search (#11130)

Signed-off-by: Ganesh Ramadurai <[email protected]>
Signed-off-by: Ganesh Ramadurai <[email protected]>
Co-authored-by: Ganesh Ramadurai <[email protected]>

* Fixing the tests for concurrent search (#11076)

* Fixing the tests for concurrent search

Signed-off-by: Bansi Kasundra <[email protected]>

* Remove changes for non-flaky tests

Signed-off-by: Bansi Kasundra <[email protected]>

---------

Signed-off-by: Bansi Kasundra <[email protected]>

* Fixed test cases for concurrent search (#11184)

Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>

---------

Signed-off-by: Jay Deng <[email protected]>
Signed-off-by: Ganesh Ramadurai <[email protected]>
Signed-off-by: Ganesh Ramadurai <[email protected]>
Signed-off-by: Bansi Kasundra <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
Co-authored-by: Ganesh Krishna Ramadurai <[email protected]>
Co-authored-by: Ganesh Ramadurai <[email protected]>
Co-authored-by: Bansi Kasundra <[email protected]>
Co-authored-by: Ethan Emoto <[email protected]>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
5 participants