Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert issue template to use GitHub issue form #11178

Closed
wants to merge 0 commits into from

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Nov 13, 2023

Description

This PR converts the issue templates to use GitHub issue form.
New component dropdown is added and requiring user to select one component from. You can see the effect in my repo https://github.com/bowenlan-amzn/OpenSearch/issues
The possible component labels are extracted from #10566
After the issue created, the workflow will be triggered and automatically triage, add the selected label to, the issue. Note that currently this is not supported by GitHub issue form out of the box, referring to https://github.com/orgs/community/discussions/4266.
This workflow is tested by this issue bowenlan-amzn#1

Related Issues

Resolves #10901

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Compatibility status:

Checks if related components are compatible with change 6bc0cd6

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for ae9acf6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ec56d57: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8077a26) 71.12% compared to head (8ea2a6b) 71.19%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11178      +/-   ##
============================================
+ Coverage     71.12%   71.19%   +0.07%     
- Complexity    58788    58807      +19     
============================================
  Files          4883     4883              
  Lines        277152   277152              
  Branches      40281    40281              
============================================
+ Hits         197134   197329     +195     
+ Misses        63545    63390     -155     
+ Partials      16473    16433      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 43a430d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bowenlan-amzn bowenlan-amzn changed the title Convert issue template to markdown Convert issue template to use GitHub form Nov 14, 2023
@bowenlan-amzn bowenlan-amzn changed the title Convert issue template to use GitHub form Convert issue template to use GitHub issue form Nov 14, 2023
Copy link
Contributor

❕ Gradle check result for a76f39a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for af79e23: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

✅ Gradle check result for 8ea2a6b: SUCCESS

Comment on lines 18 to 38
- Search:Resiliency
- Search:Performance
- Search:Query Capabilities
- Search:Query Insights
- Search:Aggregations
- Search:Remote Search
- Search:Relevance
- Search:Searchable Snapshots
- Search
- Indexing:Replication
- Indexing:Performance
- Indexing
- Storage:Snapshots
- Storage:Performance
- Storage:Durability
- Storage:Remote
- Storage
- Cluster Manager
- Extensions
- Build Libraries & Interfaces
- Plugins
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these show up in the dropdown in the order given here? If so, can we sort these alphabetically?

I agree with leaving the "general" labels below the more specific ones (i.e. Search would come after Search:Searchable Snapshots), but otherwise, I think it would be a lot easier if the whole thing were sorted. Thanks!

Copy link
Contributor

❕ Gradle check result for 6bc0cd6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2
Copy link
Member

mch2 commented Dec 5, 2023

@bowenlan-amzn are you still working on this? curious why it was closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authors to assign component's label
3 participants