-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test RemoteIndexShardtests.testRepicaCleansUpOldCommitsWhenReceivingNew #11111
Conversation
…ReceivingNew Signed-off-by: Marc Handalian <[email protected]>
Compatibility status:Checks if related components are compatible with change f0a3902 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #11111 +/- ##
============================================
+ Coverage 71.20% 71.33% +0.12%
- Complexity 58716 58836 +120
============================================
Files 4872 4872
Lines 276773 276773
Branches 40240 40240
============================================
+ Hits 197078 197436 +358
+ Misses 63238 62859 -379
- Partials 16457 16478 +21 |
…ReceivingNew (#11111) Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 3bbc495) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ReceivingNew (#11111) (#11116) (cherry picked from commit 3bbc495) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ReceivingNew (opensearch-project#11111) Signed-off-by: Marc Handalian <[email protected]>
…ReceivingNew (opensearch-project#11111) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Recent failures in this test are due to a hardcoded assertion on the segments file name.
I haven't been able to reproduce this locally, but the replica must be performing an additional commit in the background before replication.
This test's purpose is to ensure old commits are cleaned up and we don't care what the actual generation value is. Made an update here to expect that we only have a single segments file and its gen is higher than the previous.
Related Issues
Resolves #10303
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.