Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable concurrent aggs for Diversified Sampler and Sampler aggs (#11087) #11105

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Nov 6, 2023

Description

Disable concurrent aggs for Diversified Sampler and Sampler aggs. See #11075 (comment) for more details.

Related Issues

Resolves #10046
Resolves #10893
Resolves #10822

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Nov 6, 2023

@reta here is the backport PR for #11087, thanks!

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Compatibility status:

Checks if related components are compatible with change b21f915

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326 jed326 force-pushed the backport/backport-11087-to-2.x branch from df45c63 to 4bb3feb Compare November 6, 2023 23:54
@jed326 jed326 requested a review from tlfeng as a code owner November 6, 2023 23:54
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326 jed326 force-pushed the backport/backport-11087-to-2.x branch from 4bb3feb to ef125b4 Compare November 7, 2023 00:33
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326 jed326 force-pushed the backport/backport-11087-to-2.x branch from ef125b4 to 9a05496 Compare November 7, 2023 01:58
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326 jed326 force-pushed the backport/backport-11087-to-2.x branch from 9a05496 to b21f915 Compare November 7, 2023 07:11
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #11105 (b21f915) into 2.x (7bf2a3a) will increase coverage by 0.00%.
Report is 4 commits behind head on 2.x.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                2.x   #11105   +/-   ##
=========================================
  Coverage     70.98%   70.98%           
+ Complexity    58932    58911   -21     
=========================================
  Files          4851     4851           
  Lines        278030   278030           
  Branches      40766    40766           
=========================================
+ Hits         197357   197370   +13     
+ Misses        63916    63901   -15     
- Partials      16757    16759    +2     
Files Coverage Δ
...s/bucket/sampler/DiversifiedAggregatorFactory.java 76.00% <0.00%> (ø)
...tions/bucket/sampler/SamplerAggregatorFactory.java 80.00% <0.00%> (ø)

... and 440 files with indirect coverage changes

@jed326
Copy link
Collaborator Author

jed326 commented Nov 7, 2023

@reta could you help merge this one too? Thanks!

@reta reta merged commit 870ecd3 into opensearch-project:2.x Nov 7, 2023
15 of 16 checks passed
@jed326 jed326 deleted the backport/backport-11087-to-2.x branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants