[Upgrade] Lucene 9.0.0 release #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
v2.0.0
|
TODO:
|
|
✅ Gradle Wrapper Validation success 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
|
✅ DCO Check Passed 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
|
❌ Gradle Precommit failure 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
|
✅ DCO Check Passed 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
|
❌ Gradle Precommit failure 52d7adf3cf035003e921e35de7deb72c03c6b9bc |
nknize
force-pushed
the
upgrade/lucene9
branch
from
52d7adf to
c40161e
Compare
|
✅ Gradle Wrapper Validation success c40161ecbcc40b9ed213028438e42f5c91d38113 |
|
❌ Gradle Check failure c40161ecbcc40b9ed213028438e42f5c91d38113 |
|
❌ Gradle Precommit failure c40161ecbcc40b9ed213028438e42f5c91d38113 |
|
✅ Gradle Wrapper Validation success 9a897b4ff762b4e92ba38b9baa33854f0414fda2 |
|
❌ Gradle Precommit failure 9a897b4ff762b4e92ba38b9baa33854f0414fda2 |
|
❌ Gradle Check failure 9a897b4ff762b4e92ba38b9baa33854f0414fda2 |
|
✅ Gradle Wrapper Validation success f94754a4c79c8b01a12a30ea1b5142971b9d887b |
|
❌ Gradle Check failure f94754a4c79c8b01a12a30ea1b5142971b9d887b |
|
❌ Gradle Precommit failure f94754a4c79c8b01a12a30ea1b5142971b9d887b |
nknize
force-pushed
the
upgrade/lucene9
branch
from
f94754a to
65dae2e
Compare
|
✅ Gradle Wrapper Validation success 65dae2e281d749ccb38e1f8aaf5f970b242a37c5 |
|
❌ Gradle Precommit failure 65dae2e281d749ccb38e1f8aaf5f970b242a37c5 |
|
❌ Gradle Check failure 65dae2e281d749ccb38e1f8aaf5f970b242a37c5 |
nknize
force-pushed
the
upgrade/lucene9
branch
from
65dae2e to
f55d91b
Compare
nknize
changed the title
dblock
approved these changes
Mar 15, 2022
| @@ -154,13 +154,6 @@ protected void addCustomXContentFields(XContentBuilder builder, Params params) t | |||
| if (segment.getSegmentSort() != null) { | |||
| toXContent(builder, segment.getSegmentSort()); | |||
| } | |||
| if (segment.ramTree != null) { | |||
There was a problem hiding this comment.
ramEstimator was removed from Lucene 9.. so we remove it from the segment stats.
|
@nknize sorry, DCO check failed for some reasons :( could you please amend the last commit? thank you |
|
❌ Gradle Check failure 636db0caafa49a4b9317831b33795cce149696ea |
Removes types from UID class along with cleaning up all obsolete MapperService dependendices. This includes removing UID from the Translog Delete operation which is no longer needed due to type dependency removal. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
This commit upgrades the core codebase from Lucene 8.9 to lucene-9.0.0. It includes all necessary refactoring of features and API changes when upgrading to a new major Lucene release. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
This reverts commit e7af399. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
|
✅ Gradle Check success 0add86fc1c87a2876266c6b63e5e7be2f7197b95 |
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-net
that referenced
this pull request
Jun 9, 2022
`OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info. Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109 See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo. Signed-off-by: Yury Fridlyand <[email protected]>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-net
that referenced
this pull request
Aug 29, 2022
* Update nuget packages (opensearch-project#88) * Cleanup - removing stale dependencies. * Fix 2 typos in scripts project * Update `scripts` project file to include all relevant objects. * Rename `master` node role to `cluster_manager` as it was done in OpenSearch. Ref: opensearch-project/OpenSearch#2480 * Remove validation for indices segments stats. `OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info. Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109 See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo. * Remove tests for `_type` validation in mapping APIs as it was removed from `OpenSearch`. Ref: opensearch-project/OpenSearch#2238 opensearch-project/OpenSearch#2480 * Remove usage of deprecated `search.remote` settings. Ref: opensearch-project/OpenSearch#1870 * Update abstractions package - patch to support OpenSearch 2.0. Update integration workflow to run tests on OpenSearch 2.0. * Rename `master_timeout` to `cluster_manager_timeout` in all APIs where it is used. * Enrich comments to already renamed `CatMaster`/`CatClusterManager` API. * Rename in `/_cluster/stats`/`cluster.stats` and `/_cluster/state`/`cluster.state`. * Add deprecation info. * Rename in comments. * Rename in test data. * Renamings in tests including `MasterEligible`, but mark it is obsolete. * Rename branch reference in scripting. * Mark `indices.exists_type`/`TypeExists` APIs as deprecated. * Update compatibility matrix and include it into `sln` file. * Add deprecation notice to all reference of `include_type_name`/`IncludeTypeName`. * Update compatibility matrix. * Remove `OpenDistro` compatibility notice. * Update repo link. * Add small README for each project being released. * Address PR opensearch-project#51 feedback. Signed-off-by: Yury-Fridlyand <[email protected]>
wbeckler
pushed a commit
to opensearch-project/opensearch-net
that referenced
this pull request
Aug 31, 2022
* Update nuget packages (#88) * Cleanup - removing stale dependencies. * Fix 2 typos in scripts project * Update `scripts` project file to include all relevant objects. * Rename `master` node role to `cluster_manager` as it was done in OpenSearch. Ref: opensearch-project/OpenSearch#2480 * Remove validation for indices segments stats. `OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info. Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109 See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo. * Remove tests for `_type` validation in mapping APIs as it was removed from `OpenSearch`. Ref: opensearch-project/OpenSearch#2238 opensearch-project/OpenSearch#2480 * Remove usage of deprecated `search.remote` settings. Ref: opensearch-project/OpenSearch#1870 * Update abstractions package - patch to support OpenSearch 2.0. Update integration workflow to run tests on OpenSearch 2.0. * Rename `master_timeout` to `cluster_manager_timeout` in all APIs where it is used. * Enrich comments to already renamed `CatMaster`/`CatClusterManager` API. * Rename in `/_cluster/stats`/`cluster.stats` and `/_cluster/state`/`cluster.state`. * Add deprecation info. * Rename in comments. * Rename in test data. * Renamings in tests including `MasterEligible`, but mark it is obsolete. * Rename branch reference in scripting. * Mark `indices.exists_type`/`TypeExists` APIs as deprecated. * Update compatibility matrix and include it into `sln` file. * Add deprecation notice to all reference of `include_type_name`/`IncludeTypeName`. * Update compatibility matrix. * Remove `OpenDistro` compatibility notice. * Update repo link. * Add small README for each project being released. * Address PR #51 feedback. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the core codebase from Lucene 8.10.1 to lucene-9.0.0 release. It includes all necessary refactoring of features and API changes when upgrading to the new major Lucene release.
relates #1067
depends on #2452