Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integ test: check for red indices and then manually restore to green #10838

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix integ test: check for red indices and then manually restore to green #10838

merged 1 commit into from
Oct 23, 2023

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Oct 23, 2023 •
edited
Loading

Description

  • Fixes failing test on main - org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT#testFullClusterRestoreDoesntFailWithConflictingLocalState

Related Issues

#10842

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@linuxpi linuxpi marked this pull request as ready for review October 23, 2023 04:00
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change b8eee3c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi self-assigned this Oct 23, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 mentioned this pull request Oct 23, 2023
Merged
8 tasks
@rahulkarajgikar rahulkarajgikar mentioned this pull request Oct 23, 2023
Merged
8 tasks
ashking94
ashking94 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets get this merged!!

@sachinpkale sachinpkale merged commit 5e7c068 into opensearch-project:main Oct 23, 2023
@linuxpi linuxpi deleted the fix-auto-restore-test branch October 23, 2023 05:54
@linuxpi
Copy link
Collaborator Author

linuxpi commented Oct 23, 2023

There are two PRs which are fixing two different test failures on main and are blocked on each other(cyclic dependency).

One this this PR other is #10835

@linuxpi linuxpi added the backport 2.x Backport to 2.x branch label Oct 23, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2023
@github-actions
fix integ test: check for red indices and then manually restore to gr…
92c7ade 
…een (#10838)

Signed-off-by: bansvaru <[email protected]>
(cherry picked from commit 5e7c068)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@linuxpi linuxpi mentioned this pull request Oct 23, 2023
Closed
sachinpkale pushed a commit that referenced this pull request Oct 23, 2023
@opensearch-trigger-bot @github-actions
fix integ test: check for red indices and then manually restore to gr…
d5d130e 
…een (#10838) (#10843)

(cherry picked from commit 5e7c068)

Signed-off-by: bansvaru <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@linuxpi @shiv0408
fix integ test: check for red indices and then manually restore to gr…
7301328 
…een (opensearch-project#10838)

Signed-off-by: bansvaru <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@linuxpi linuxpi

Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linuxpi @sachinpkale @ashking94