Shard id awareness of SearchLookup

[anti-social]

Signed-off-by: Oleksandr Koval [email protected]

Description

Add shardId field for SearchLookup.

Issues Resolved

#1062

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR [created](https://github.com/opensearch-project/documentation-website/issues/new/choose

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   DCO Check Passed a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4

[opensearch-ci-bot]

✅   DCO Check Passed 3314a8069f91480db129fac4e0f92507ca42a768

[opensearch-ci-bot]

❌   Gradle Precommit failure a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4
Log 902

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 3314a8069f91480db129fac4e0f92507ca42a768

[opensearch-ci-bot]

✅   Gradle Precommit success 3314a8069f91480db129fac4e0f92507ca42a768

[opensearch-ci-bot]

Can one of the admins verify this patch?

[adnapibar]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 3314a8069f91480db129fac4e0f92507ca42a768
Log 671

Reports 671

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 3314a8069f91480db129fac4e0f92507ca42a768

[opensearch-ci-bot]

✅   DCO Check Passed 3314a8069f91480db129fac4e0f92507ca42a768

[opensearch-ci-bot]

✅   Gradle Precommit success 3314a8069f91480db129fac4e0f92507ca42a768

[anasalkouz]

@anti-social , can you look into the failure and resolve the conflict.

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd

[opensearch-ci-bot]

✅   Gradle Precommit success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd

[opensearch-ci-bot]

❌   Gradle Check failure 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd
Log 950

Reports 950

[anti-social]

Think this test are not related to the changes:

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED

./gradlew :server:internalClusterTest --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" passed on my machine.

Possibly checks should be retried.

[tlfeng]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd
Log 991

Reports 991

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 4254bab

[opensearch-ci-bot]

✅   Gradle Precommit success 4254bab

[opensearch-ci-bot]

✅   Gradle Check success 4254bab
Log 1006

Reports 1006

[opensearch-ci-bot]

❌   Gradle Check failure 4254bab
Log 1425

Reports 1425

[opensearch-ci-bot]

✅   Gradle Check success 4254bab
Log 1473

Reports 1473

[dblock]

@anti-social Could you please explain what this is for? I imagine you want to pass in an actual shard ID sometimes, so it seems at least that this PR still needs tests for searches with a known shard ID. And maybe default the value to UNKNOWN_SHARD_ID in the public interfaces.

[github-actions]

✅ Gradle check result for 1b55506: SUCCESS

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a50d1f6) 71.38% compared to head (49ddd28) 71.37%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
.../org/opensearch/index/query/QueryShardContext.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1063      +/-   ##
============================================
- Coverage     71.38%   71.37%   -0.01%     
- Complexity    59848    59891      +43     
============================================
  Files          4972     4972              
  Lines        281774   281781       +7     
  Branches      40910    40910              
============================================
- Hits         201138   201116      -22     
- Misses        63973    63999      +26     
- Partials      16663    16666       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anti-social]

@andrross @msfroh Could you review it?

[andrross]

I added a unit test for the deprecated constructor behavior, and made a cosmetic change to another unit test. @msfroh can you take a look and merge if it looks good to you?

Comments have been addressed

[github-actions]

❌ Gradle check result for caea317: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for e45ff9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 49ddd28: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testNoSearchIdleForAnyReplicaCount

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-1063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87ac37460c16a5b3cfa1cd85cad2cb7468b430a3
# Push it to GitHub
git push --set-upstream origin backport/backport-1063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1063-to-2.x.