Fix broken test testCommitOnCloseThrowsException_decRefStore

[mch2]

Description

This test was incorrectly hardcoding a segment to delete to force corruption. If a merge occurs randomly before segments are copied the expected segment did not exist failing the test. This will now look for any .si and delete it.

Related Issues

Resolves #10616

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

Thanks a lot @mch2 !

[github-actions]

Compatibility status:

Checks if related components are compatible with change f281e10

Incompatible components

Incompatible components: [https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromLocalNode

• URL: https://build.ci.opensearch.org/job/gradle-check/27863/
• CommitID: f281e10
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10621 (f281e10) into main (6c02261) will increase coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10621      +/-   ##
============================================
+ Coverage     71.12%   71.27%   +0.15%     
- Complexity    58391    58451      +60     
============================================
  Files          4845     4845              
  Lines        275335   275335              
  Branches      40088    40088              
============================================
+ Hits         195827   196257     +430     
+ Misses        63147    62645     -502     
- Partials      16361    16433      +72     

Files	Coverage Δ
...kpressure/settings/SearchBackpressureSettings.java	92.59% <ø> (ø)

... and 504 files with indirect coverage changes