Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JCenter with Maven Central. #1057

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Replace JCenter with Maven Central. #1057

merged 1 commit into from
Aug 10, 2021

Conversation

adnapibar
Copy link
Contributor

Description

https://blog.gradle.org/jcenter-shutdown

Issues Resolved

#1055

Check List

  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

@adnapibar
Replace JCenter with Maven Central.
ff06789 
Replace with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
@adnapibar adnapibar added the v2.0.0 Version 2.0.0 label Aug 6, 2021
adnapibar
adnapibar commented Aug 6, 2021
View reviewed changes
buildSrc/build.gradle
@@ -94,7 +94,8 @@ tasks.withType(JavaCompile).configureEach {
*****************************************************************************/

repositories {
jcenter()
mavenCentral()
gradlePluginPortal()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For plugins not in mavenCentral() as a fallback. The Gradle Plugin Portal implicitly mirrors JCenter currently.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success ff06789

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed ff06789

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success ff06789

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ff06789
Log 376

Reports 376

saratvemulapalli
saratvemulapalli reviewed Aug 9, 2021
View reviewed changes
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what dependencies of OpenSearch, we rely on jcenter() today?

I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

@adnapibar
Copy link
Contributor Author

On what dependencies of OpenSearch, we rely on jcenter() today?

I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

All dependencies are resolved through jcenter today. This change removes that and uses mavenCentral instead.

@saratvemulapalli
Copy link
Member

On what dependencies of OpenSearch, we rely on jcenter() today?
I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

All dependencies are resolved through jcenter today. This change removes that and uses mavenCentral instead.

Thanks for helping me understand. It would be nice to see this as description for the PR.

@adnapibar
Copy link
Contributor Author

Thanks for helping me understand. It would be nice to see this as description for the PR.

Thanks:) The linked issue has all the details.

@adnapibar adnapibar linked an issue Aug 10, 2021 that may be closed by this pull request
Replace JCenter with Maven Central for Gradle Build #1055
Closed
@adnapibar adnapibar merged commit e78040a into opensearch-project:main Aug 10, 2021
krishna-ggk pushed a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 16, 2021
@adnapibar @krishna-ggk
Replace JCenter with Maven Central. (opensearch-project#1057)
7151fc9 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
@reta reta mentioned this pull request Nov 29, 2021
Merged
5 tasks
@adnapibar adnapibar deleted the maven-central branch December 26, 2021 18:37
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
@adnapibar @mch2
Replace JCenter with Maven Central. (opensearch-project#1057)
8e45787 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
@mch2 mch2 mentioned this pull request Jan 12, 2022
Closed
20 tasks
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
@adnapibar @mch2
Replace JCenter with Maven Central. (opensearch-project#1057)
47f4233 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
@mch2 mch2 mentioned this pull request Jan 12, 2022
Merged
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
@adnapibar @mch2
Replace JCenter with Maven Central. (opensearch-project#1057)
63dc859 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
@adnapibar @mch2
Replace JCenter with Maven Central. (opensearch-project#1057)
d33ef8d 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
CEHENKLE pushed a commit that referenced this pull request Jan 12, 2022
@mch2 @adnapibar
[Backport 1.2] Replace JCenter with Maven Central. (#1057) and update…
afdaae4 
… plugin repository order. (#1894)

* Replace JCenter with Maven Central. (#1057)

On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>

* Define plugin repositories order in settings.gradle.

Signed-off-by: Marc Handalian <[email protected]>

Co-authored-by: Rabi Panda <[email protected]>
CEHENKLE pushed a commit that referenced this pull request Jan 13, 2022
@mch2 @adnapibar
Replace JCenter with Maven Central. (#1057) (#1892)
fc198ed 
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>

Co-authored-by: Rabi Panda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace JCenter with Maven Central for Gradle Build
3 participants
@adnapibar @opensearch-ci-bot @saratvemulapalli