Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt bash path support #1047

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

hackacad
Copy link
Contributor

@hackacad hackacad commented Aug 4, 2021

Signed-off-by: hackacad [email protected]

Description

Using portable shebangs as mentioned in #1013.

Not using env for /bin/sh as this should be present on every Linux/Unix.

Issues Resolved

#1013

mention opensearch-project/opensearch-build#101

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: hackacad <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 1a6870c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 1a6870c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 1a6870c

@dblock
Copy link
Member

dblock commented Aug 4, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1a6870c
Log 369

Reports 369

@dblock
Copy link
Member

dblock commented Aug 5, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1a6870c
Log 371

Reports 371

@dblock dblock merged commit dcd9cef into opensearch-project:main Aug 6, 2021
@dblock
Copy link
Member

dblock commented Aug 6, 2021

Merged, thank you!

Do we want these changes in 1.1? If you think we do, make backport PRs into 1.1 please @hackacad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants