-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.11] Performance Improvement for Datetime formats to 2.11 #10453
[Backport 2.11] Performance Improvement for Datetime formats to 2.11 #10453
Conversation
…project#9567) * Added performance improvement for datetime field parsing This adds caching of formatters in case of no explicit format specified for the datetime field in mapping. This also adds `strict_date_time_no_millis` as additional formatter in default date time formats Signed-off-by: Prabhat Sharma <[email protected]> * Refactor DateTimeFormatter Access under featireflag Signed-off-by: Prabhat Sharma <[email protected]> --------- Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit 2965e69) Signed-off-by: Prabhat Sharma <[email protected]> (cherry picked from commit 5a459ba)
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change fbddd58 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git] |
* Race condition fix for datetime optimization Signed-off-by: Prabhat Sharma <[email protected]> * Changed JavaDateTimeFormatter caching of parser from MRU(most recently used) to a simple last used formatter Signed-off-by: Prabhat Sharma <[email protected]> --------- Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> Signed-off-by: Prabhat Sharma <[email protected]> (cherry picked from commit ad17b38) Signed-off-by: Prabhat Sharma <[email protected]>
4112eba
to
fbddd58
Compare
Trigerring build for flaky test to pass |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.11 #10453 +/- ##
============================================
+ Coverage 70.86% 70.92% +0.06%
- Complexity 58501 58573 +72
============================================
Files 4829 4829
Lines 276344 276424 +80
Branches 40578 40589 +11
============================================
+ Hits 195821 196046 +225
+ Misses 63808 63720 -88
+ Partials 16715 16658 -57
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m pretty sure 2.11 only takes bug fixes since yesterday, but @CEHENKLE can correct me if I’m wrong
That's is correct, this is a backport for |
Yeah, the only place it gets weird is when we haven't cut the release branch yet, and by default 2.x is the release branch. So unless it creates problems/more work for the release managers (@bbarani or @gaiksaya or @rishabh6788 or @peterzhuamazon or anyone else :) ) then it's fine with me :) |
This one is into a branch called 2.11, so should we not take it here and close this PR? |
Yeah -- I'm going to go ahead and close this one, since it sounds like we're all on the same page about not backporting to 2.11. (2.x is fine.) Feel free to reopen if I'm wrong. |
Description
Backport changes #9567 and #10385
Related Issues
Resolves #4558
Public doc: opensearch-project/documentation-website#5163
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.