Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Upgrade Lucene to 9.8.0 #10360

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 4, 2023

Description

Upgrade Lucene to 9.8.0

Related Issues

See please #10031, #8668, #10276

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • GitHub issue/PR created in OpenSearch documentation repo for the required public documentation changes (#[Issue/PR number])

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

@dblock @msfroh @CEHENKLE @heemin32 @andrross @nknize @model-collapse opening up the pull request to bring 9.8.0 to 2.x (and possibly, 2.11 as there are some hesitations).

@reta reta added the backport PRs or issues specific to backporting features or enhancments label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Compatibility status:

Checks if related components are compatible with change 7f41003

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@CEHENKLE CEHENKLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey -- given that today to the last day to merge changes for 2.11, I think we should hold this because of the potential impact.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

Hey -- given that today to the last day to merge changes for 2.11, I think we should hold this because of the potential impact.

Sure, we'll wait till 2.11 cut off, thanks @CEHENKLE !

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@CEHENKLE
Copy link
Member

CEHENKLE commented Oct 4, 2023

Hey -- given that today to the last day to merge changes for 2.11, I think we should hold this because of the potential impact.

Sure, we'll wait till 2.11 cut off, thanks @CEHENKLE !

Thanks, @reta!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #10360 (7f41003) into 2.x (422cf06) will increase coverage by 0.14%.
Report is 1 commits behind head on 2.x.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##                2.x   #10360      +/-   ##
============================================
+ Coverage     70.83%   70.98%   +0.14%     
- Complexity    58509    58603      +94     
============================================
  Files          4830     4830              
  Lines        276386   276387       +1     
  Branches      40580    40579       -1     
============================================
+ Hits         195788   196199     +411     
+ Misses        63877    63506     -371     
+ Partials      16721    16682      -39     
Files Coverage Δ
...ibs/core/src/main/java/org/opensearch/Version.java 83.18% <100.00%> (-1.30%) ⬇️
...rg/opensearch/index/engine/TranslogLeafReader.java 38.00% <ø> (ø)
...search/suggest/completion/CompletionSuggester.java 2.77% <0.00%> (-0.08%) ⬇️
...main/java/org/opensearch/common/lucene/Lucene.java 68.13% <0.00%> (+1.25%) ⬆️
...dex/search/comparators/UnsignedLongComparator.java 0.00% <0.00%> (ø)

... and 487 files with indirect coverage changes

@reta
Copy link
Collaborator Author

reta commented Oct 6, 2023

Hey -- given that today to the last day to merge changes for 2.11, I think we should hold this because of the potential impact.

Sure, we'll wait till 2.11 cut off, thanks @CEHENKLE !

Thanks, @reta!

@CEHENKLE the 2.11 is cut, 2.x is on 2.12 now, we should be good to merge it, thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this into 2.x.

Copy link
Member

@CEHENKLE CEHENKLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot woot :)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Andriy Redko <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@reta reta merged commit a287edc into opensearch-project:2.x Oct 11, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants