Add header verification netty channel handler #10290
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an entry point for header verification in Netty4HttpServerTransport, using netty channel close allows for fewer downstream changes.
Based off work of @cwperks in #10261
Draft Status
This pull request has a very naïve test strategy, it should be looked into more deeply to be sure there aren't other side effects.
Note; it is also possible that this approach isn't needed at all if the Netty pipeline construction can be modified by the extensions of the AbstractHttpServerTransport class. More research is needed in this space.
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.