-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing extra protobuf notice file #10114
Removing extra protobuf notice file #10114
Conversation
Compatibility status:Checks if related components are compatible with change 34cbc6b Incompatible componentsIncompatible components: [https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Flaky test reported in #10133 |
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Flaky test reported in #10133 |
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Flaky test again #10006 |
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Ugh. This gradle check history is bad. :( |
e97b051
to
34cbc6b
Compare
Yeah :( I just force pushed with a rebase. Thank you! |
Gradle Check (Jenkins) Run Completed with:
|
testPrimaryTermValidation failing again. #10133 |
@kotwanikunal Any suggestions to get a clean gradle check? :( |
I wish there was another way out. I re-ran it 🤞 |
Gradle Check (Jenkins) Run Completed with:
|
Finally 🎊 Thanks @kotwanikunal! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10114-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05ee0c3f3f8b347371a9f77f89023d1ec9851707
# Push it to GitHub
git push --set-upstream origin backport/backport-10114-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* Removing the extra protobuf java notice from root Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit errors Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
* Removing the extra protobuf java notice from root Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit errors Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
* Removing the extra protobuf java notice from root Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit errors Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
* Removing the extra protobuf java notice from root Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit errors Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Same as title
Related Issues
Resolves #9287
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.