Update single comment for gradle check

[andrross]

This is the same change that was applied to the check comptability task by PR #9954 to update a single comment with the latest result of the gradle check workflow.

Relates #9699

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 8fa743f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

• URL: https://build.ci.opensearch.org/job/gradle-check/25655/
• CommitID: 8fa743f
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10057 (8fa743f) into main (71f6136) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10057      +/-   ##
============================================
- Coverage     71.10%   71.06%   -0.04%     
- Complexity    58070    58080      +10     
============================================
  Files          4824     4824              
  Lines        273918   273918              
  Branches      39918    39918              
============================================
- Hits         194768   194666     -102     
- Misses        62802    62948     +146     
+ Partials      16348    16304      -44     

see 441 files with indirect coverage changes

[kotwanikunal]

I think there was a similar proposal by @scrawfor99 (You can follow the thread here: #8488 (comment))

I still have the same concerns that we have no easy way of tracking the check results otherwise.

[andrross]

I think there was a similar proposal by @scrawfor99 (You can follow the thread here: #8488 (comment))

I still have the same concerns that we have no easy way of tracking the check results otherwise.

@kotwanikunal Thanks, I had missed #8488. I'm not sure I agree with the concerns about tracking...the GitHub comment will show up as "edited" and allow you to view every revision. Each revision has the commit SHA that was tested as well. This change brings the gradle check in line with how codecov and check compatibility behave.

The point about notifications does stand though because I don't think GitHub will fire off a notification for a comment edit.

[reta]

@andrross I somewhat missed that this is the change for Gradle check (vs compatibility check), I am 100% with @kotwanikunal on that, the notification is very useful to have for this check at all times.

[andrross]

the notification is very useful to have for this check at all times.

Thanks @reta. That's reasonable so I'll go ahead and close this one. If you don't mind, can you leave your opinion on #9767 to cancel concurrent check workflows to avoid notifications for runs against a commit that has been superseded by a new commit? (I'm on a kick recently to reduce the noise in our PR comment feeds :) ).