Updating comment and small refactoring

Signed-off-by: Rishikesh1159 <[email protected]>
opensearch-project · Apr 12, 2022 · abced8c · abced8c
1 parent 1670ba1
commit abced8c
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 26 deletions.
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/...src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java b/...src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
@@ -234,14 +234,7 @@ public void testDeleteOperations() throws Exception {
         final String nodeA = internalCluster().startNode();
         final String nodeB = internalCluster().startNode();
 
-        createIndex(
-            INDEX_NAME,
-            Settings.builder()
-                .put(IndexMetadata.SETTING_NUMBER_OF_SHARDS, SHARD_COUNT)
-                .put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, REPLICA_COUNT)
-                .put(IndexMetadata.SETTING_SEGMENT_REPLICATION, true)
-                .build()
-        );
+        createIndex(INDEX_NAME);
         ensureGreen(INDEX_NAME);
         client().prepareIndex(INDEX_NAME).setId("1").setSource("foo", "bar").setRefreshPolicy(WriteRequest.RefreshPolicy.WAIT_UNTIL).get();
 

diff --git a/server/src/main/java/org/opensearch/index/engine/InternalEngine.java b/server/src/main/java/org/opensearch/index/engine/InternalEngine.java
@@ -718,12 +718,11 @@ private ExternalReaderManager createReaderManager(RefreshWarmerListener external
 
     private DirectoryReader getDirectoryReader() throws IOException {
         // for segment replication: replicas should create the reader from store and, we don't want an open IW on replicas.
-        /* We should always wrap replicas with a SoftDeletesDirectoryReaderWrapper as we use soft deletes when segment replication is on for
-        deletions */
+        // We should always wrap the DirectoryReader used on replicas with SoftDeletesDirectoryReaderWrapper so that we filter out soft deletes
         if (engineConfig.isReadOnly()) {
             return new SoftDeletesDirectoryReaderWrapper(DirectoryReader.open(store.directory()), Lucene.SOFT_DELETES_FIELD);
         }
-        return DirectoryReader.open(indexWriter, true, true);
+        return DirectoryReader.open(indexWriter);
     }
 
     @Override