Skip to content

Commit

Permalink
Responded to feedback from Andrew Ross, fixed typo, spelling, added s…
Browse files Browse the repository at this point in the history
…hudownNow() and Thread.currentThread().interrupt()

Signed-off-by: Chengwu Shi <[email protected]>
  • Loading branch information
chengwushi-netapp committed May 14, 2024
1 parent d15d2fb commit 280dd0a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased 2.x]
### Added
- Added support for Azure Managed Identity in repository-azure ([#12423](https://github.com/opensearch-project/OpenSearch/issues/12423))
- Add support for Azure Managed Identity in repository-azure ([#12423](https://github.com/opensearch-project/OpenSearch/issues/12423))
- Add useCompoundFile index setting ([#13478](https://github.com/opensearch-project/OpenSearch/pull/13478))
- Make outbound side of transport protocol dependent ([#13293](https://github.com/opensearch-project/OpenSearch/pull/13293))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,11 @@ public void close() throws IOException {
this.executor.shutdown();
try {
if (this.executor.awaitTermination(30, TimeUnit.SECONDS) == false) {
logger.warning("The executor was not shutdown gracefuly with 30 seconds");
this.executor.shutdownNow();
logger.warning("The executor was not shutdown gracefully with 30 seconds");

Check warning on line 340 in plugins/repository-azure/src/main/java/org/opensearch/repositories/azure/AzureStorageService.java

View check run for this annotation

Codecov / codecov/patch

plugins/repository-azure/src/main/java/org/opensearch/repositories/azure/AzureStorageService.java#L339-L340

Added lines #L339 - L340 were not covered by tests
}
} catch (final InterruptedException ex) {
Thread.currentThread().interrupt();
throw new IOException(ex);

Check warning on line 344 in plugins/repository-azure/src/main/java/org/opensearch/repositories/azure/AzureStorageService.java

View check run for this annotation

Codecov / codecov/patch

plugins/repository-azure/src/main/java/org/opensearch/repositories/azure/AzureStorageService.java#L342-L344

Added lines #L342 - L344 were not covered by tests
}
}
Expand Down

0 comments on commit 280dd0a

Please sign in to comment.