Giving informative error messages for double slashes in API call URLs (…

…#1568) * Signed-off-by: Megha Sai Kavikondala <[email protected]> Changes related to Informative error messages. * Signed-off-by: Megha Sai Kavikondala <[email protected]> Spotless changes * Signed-off-by: Megha Sai Kavikondala <[email protected]> naming and message changes. Signed-off-by: Megha Sai Kavikondala <[email protected]> * Signed-off-by: Megha Sai Kavikondala <[email protected]> Deleting the log message.
opensearch-project · Nov 22, 2021 · 12a2294 · 12a2294
1 parent 0c21689
commit 12a2294
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java b/server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
@@ -250,6 +250,9 @@ public static void validateIndexOrAliasName(String index, BiFunction<String, Str
         if (!Strings.validFileName(index)) {
             throw exceptionCtor.apply(index, "must not contain the following characters " + Strings.INVALID_FILENAME_CHARS);
         }
+        if (index.isEmpty()) {
+            throw exceptionCtor.apply(index, "must not be empty");
+        }
         if (index.contains("#")) {
             throw exceptionCtor.apply(index, "must not contain '#'");
         }

diff --git a/server/src/test/java/org/opensearch/cluster/metadata/MetadataCreateIndexServiceTests.java b/server/src/test/java/org/opensearch/cluster/metadata/MetadataCreateIndexServiceTests.java
@@ -626,6 +626,8 @@ public void testValidateIndexName() throws Exception {
             validateIndexName(checkerService, "..", "must not be '.' or '..'");
 
             validateIndexName(checkerService, "foo:bar", "must not contain ':'");
+
+            validateIndexName(checkerService, "", "Invalid index name [], must not be empty");
         }));
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -626,6 +626,8 @@ public void testValidateIndexName() throws Exception { @@
                 validateIndexName(checkerService, "..", "must not be '.' or '..'");
                 validateIndexName(checkerService, "foo:bar", "must not contain ':'");
+                validateIndexName(checkerService, "", "Invalid index name [], must not be empty");
             }));
         }
@@ Expand Down @@