Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Update workspace privacy setting link #9222

Merged

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Jan 20, 2025

Description

This PR is for updating workspace privacy setting link in workspace collaborators flyout. The link hash has been changed in this documentation website PR. Should change to#configuring-workspace-privacy in the flyout.

Testing the changes

  • Clone the documentation website repo
  • Follow this doc and run docker compose -f docker-compose.dev.yml up in documentation website repo
  • The documentation website should be available on http://0.0.0.0:4000/docs/latest/
  • Clone current branch and run yarn osd bootstrap --single-version loose
  • Add the following configurations to config/opensearch_dashboards.yml:
   savedObjects.permission.enabled: true
   workspace.enabled: true
   uiSettings:
     overrides:
       'home:useNewHomePage': true
  • Modify OPENSEARCH_WEBSITE_URL to 'http://0.0.0.0:4000/' in src/core/public/doc_links/doc_links_service.ts
  • Create a workspace
  • Enter workspace collaborators page
  • Click "Learn more"
  • Click the first "Learn more in documentation" link, it should take to the correct privacy configuration section

Changelog

  • feat: [Workspace]Update workspace privacy setting link

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.66%. Comparing base (a7aeb76) to head (392d173).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9222   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files        3817     3817           
  Lines       91711    91711           
  Branches    14515    14515           
=======================================
  Hits        56556    56556           
  Misses      31525    31525           
  Partials     3630     3630           
Flag Coverage Δ
Linux_1 29.04% <ø> (ø)
Linux_2 56.45% <ø> (ø)
Linux_3 39.09% <ø> (ø)
Linux_4 28.98% <ø> (ø)
Windows_1 29.05% <ø> (ø)
Windows_2 56.40% <ø> (ø)
Windows_3 39.09% <ø> (ø)
Windows_4 28.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lin Wang <[email protected]>
Hailong-am
Hailong-am previously approved these changes Jan 20, 2025
@Hailong-am
Copy link
Collaborator

One test failed due to snapshot mismatch

Signed-off-by: Lin Wang <[email protected]>
@Hailong-am Hailong-am merged commit b0bfa6c into opensearch-project:main Jan 20, 2025
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 20, 2025
* Update workspace acl privacy setting link

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #9222 created/updated

* Fix failed snapshots

Signed-off-by: Lin Wang <[email protected]>

* Fix failed snapshots

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b0bfa6c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Jan 21, 2025
* Update workspace acl privacy setting link



* Changeset file for PR #9222 created/updated

* Fix failed snapshots



* Fix failed snapshots



---------



(cherry picked from commit b0bfa6c)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants