-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Update workspace privacy setting link #9222
Merged
Hailong-am
merged 5 commits into
opensearch-project:main
from
wanglam:feat-update-workspace-privacy-type
Jan 20, 2025
Merged
[Workspace]Update workspace privacy setting link #9222
Hailong-am
merged 5 commits into
opensearch-project:main
from
wanglam:feat-update-workspace-privacy-type
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9222 +/- ##
=======================================
Coverage 61.66% 61.66%
=======================================
Files 3817 3817
Lines 91711 91711
Branches 14515 14515
=======================================
Hits 56556 56556
Misses 31525 31525
Partials 3630 3630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
January 20, 2025 05:54
Signed-off-by: Lin Wang <[email protected]>
Hailong-am
previously approved these changes
Jan 20, 2025
One test failed due to snapshot mismatch |
Signed-off-by: Lin Wang <[email protected]>
ruanyl
approved these changes
Jan 20, 2025
Hailong-am
approved these changes
Jan 20, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Update workspace acl privacy setting link Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #9222 created/updated * Fix failed snapshots Signed-off-by: Lin Wang <[email protected]> * Fix failed snapshots Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b0bfa6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Update workspace acl privacy setting link * Changeset file for PR #9222 created/updated * Fix failed snapshots * Fix failed snapshots --------- (cherry picked from commit b0bfa6c) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for updating workspace privacy setting link in workspace collaborators flyout. The link hash has been changed in this documentation website PR. Should change to
#configuring-workspace-privacy
in the flyout.Testing the changes
docker compose -f docker-compose.dev.yml up
in documentation website repohttp://0.0.0.0:4000/docs/latest/
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
:OPENSEARCH_WEBSITE_URL
to 'http://0.0.0.0:4000/' insrc/core/public/doc_links/doc_links_service.ts
Changelog
Check List
yarn test:jest
yarn test:jest_integration