Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix the display and jump logic for recent assets #9174

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e1b12ab from #8136.

* Hide global objects in recent assets when workspace enabled, and jump to the global for workspace objects hwen workspace disabled

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #8136 created/updated

* Update recently-accessed-service

Signed-off-by: Kapian1234 <[email protected]>

* fix the boolean value

Signed-off-by: Kapian1234 <[email protected]>

* add unit test and fix some bugs

Signed-off-by: Kapian1234 <[email protected]>

* rename test cases

Signed-off-by: Kapian1234 <[email protected]>

* Pass workspaceEnabled to createRecentNavLink

Signed-off-by: Kapian1234 <[email protected]>

* Update unit tests

Signed-off-by: Kapian1234 <[email protected]>

* Remove workspaceEnabled props in recent_items

Signed-off-by: Kapian1234 <[email protected]>

* Fix links at recent accessed items

Signed-off-by: Kapian1234 <[email protected]>

* Fix unit tests

Signed-off-by: Kapian1234 <[email protected]>

* Update snapshots

Signed-off-by: Kapian1234 <[email protected]>

* Modify unit tests

Signed-off-by: Kapian1234 <[email protected]>

---------

Signed-off-by: Kapian1234 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit e1b12ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (b5002db) to head (c7a296e).
Report is 8 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ome/recently_accessed/recently_accessed_service.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #9174      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files        3811     3811              
  Lines       91318    91322       +4     
  Branches    14414    14416       +2     
==========================================
+ Hits        55685    55687       +2     
  Misses      32102    32102              
- Partials     3531     3533       +2     
Flag Coverage Δ
Linux_1 29.10% <0.00%> (-0.01%) ⬇️
Linux_2 56.59% <85.71%> (+<0.01%) ⬆️
Linux_3 37.82% <0.00%> (-0.01%) ⬇️
Linux_4 30.04% <12.50%> (-0.01%) ⬇️
Windows_1 29.12% <0.00%> (-0.01%) ⬇️
Windows_2 56.54% <85.71%> (+<0.01%) ⬆️
Windows_3 37.82% <0.00%> (-0.01%) ⬇️
Windows_4 30.04% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 00146b5 into 2.x Jan 17, 2025
69 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-8136-to-2.x branch January 17, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.19.0 valued-contributor workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants