-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix the display and jump logic for recent assets #9174
Conversation
* Hide global objects in recent assets when workspace enabled, and jump to the global for workspace objects hwen workspace disabled Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #8136 created/updated * Update recently-accessed-service Signed-off-by: Kapian1234 <[email protected]> * fix the boolean value Signed-off-by: Kapian1234 <[email protected]> * add unit test and fix some bugs Signed-off-by: Kapian1234 <[email protected]> * rename test cases Signed-off-by: Kapian1234 <[email protected]> * Pass workspaceEnabled to createRecentNavLink Signed-off-by: Kapian1234 <[email protected]> * Update unit tests Signed-off-by: Kapian1234 <[email protected]> * Remove workspaceEnabled props in recent_items Signed-off-by: Kapian1234 <[email protected]> * Fix links at recent accessed items Signed-off-by: Kapian1234 <[email protected]> * Fix unit tests Signed-off-by: Kapian1234 <[email protected]> * Update snapshots Signed-off-by: Kapian1234 <[email protected]> * Modify unit tests Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit e1b12ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #9174 +/- ##
==========================================
- Coverage 60.97% 60.97% -0.01%
==========================================
Files 3811 3811
Lines 91318 91322 +4
Branches 14414 14416 +2
==========================================
+ Hits 55685 55687 +2
Misses 32102 32102
- Partials 3531 3533 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport e1b12ab from #8136.