Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

Merged
merged 16 commits into from
Jan 16, 2025
Merged

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

merged 16 commits into from
Jan 16, 2025

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Jan 9, 2025 •
edited
Loading

Description

Adds a Cypress test suite for Saved Queries Test Scope.

Issues Resolved

Closes #8975, #8977, #8978, #8979, #8980

Screenshot

newUICompressed.mp4
oldUICompressed.mp4

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see 2 new test specs saved_queries.spec.js and saved_queries_old_ui.spec.js. Run saved_queries.spec.js if data.savedQueriesNewUI.enabled: true in the OSD config, else run saved_queries_old_ui.spec.js.

Changelog

  • test: Add cypress integration test for the old and new UI view saved queries.

@ArgusLi ArgusLi requested a review from huyaboo as a code owner January 9, 2025 18:17
@ArgusLi ArgusLi changed the title [Discover 2.0 Testing] Create View Saved Queries Test (Test-Id 124: List Saved Queries) [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) Jan 9, 2025
angle943
angle943 suggested changes Jan 10, 2025
View reviewed changes
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js Outdated Show resolved Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js Outdated Show resolved Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js Outdated Show resolved Hide resolved
...search-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries_old_ui.spec.js Outdated Show resolved Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js Outdated Show resolved Hide resolved
...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js Outdated Show resolved Hide resolved
cypress/utils/apps/data_explorer/commands.js Outdated Show resolved Hide resolved
cypress/utils/apps/data_explorer/commands.js Outdated Show resolved Hide resolved
cypress/utils/apps/data_explorer/commands.js Outdated Show resolved Hide resolved
cypress/utils/apps/query_enhancements/commands.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (e450f4d) to head (6297366).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lugins/data/public/ui/saved_query_form/helpers.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9166   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3813     3813           
  Lines       91401    91401           
  Branches    14443    14443           
=======================================
  Hits        55770    55770           
  Misses      32068    32068           
  Partials     3563     3563
Flag Coverage Δ
Linux_1 29.08% <ø> (ø)
Linux_2 56.45% <ø> (ø)
Linux_3 38.02% <0.00%> (-0.01%) ⬇️
Linux_4 29.03% <ø> (ø)
Windows_1 29.09% <ø> (ø)
Windows_2 56.40% <ø> (ø)
Windows_3 38.03% <0.00%> (ø)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgusLi
Remove final force.
4ae05a4 
Signed-off-by: Argus Li <[email protected]>
@ArgusLi
Rename specs, change cypress workflow to use new save query ui, merge…
3c2b2ec 
… old ui and new ui commands

Signed-off-by: Argus Li <[email protected]>
@ArgusLi
Merge main
59de88e 
Signed-off-by: Argus Li <[email protected]>
@ArgusLi
fix import
6297366 
Signed-off-by: Argus Li <[email protected]>
@ananzh ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Jan 16, 2025
@ananzh
Copy link
Member

ananzh commented Jan 16, 2025

ciGroup 10 failure is a known issue and @angle943 is working on it

@LDrago27 LDrago27 merged commit 33f7ba6 into opensearch-project:main Jan 16, 2025
69 of 71 checks passed
d-buckner pushed a commit to d-buckner/OpenSearch-Dashboards that referenced this pull request Jan 17, 2025
@ArgusLi @opensearch-changeset-bot @d-buckner
[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-I…
4b25e62 
…d 124: View list of Saved query) (opensearch-project#9166)

* add spec for old ui

Signed-off-by: Argus Li <[email protected]>

* Add comment about cleaning up saved queries

Signed-off-by: Argus Li <[email protected]>

* Add data-test-subj for save query new ui

Signed-off-by: Argus Li <[email protected]>

* Add data-test-subj for save query button for new ui

Signed-off-by: Argus Li <[email protected]>

* Add data-test-subj for open query button in query management popover

Signed-off-by: Argus Li <[email protected]>

* Add new ui spec to test list saved queries

Signed-off-by: Argus Li <[email protected]>

* Fix DataSource url

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9166 created/updated

* Address Justin's comments.

Signed-off-by: Argus Li <[email protected]>

* Remove final force.

Signed-off-by: Argus Li <[email protected]>

* Fix final force.

Signed-off-by: Argus Li <[email protected]>

* Move utils to Suchit's suggested location, fix comments

Signed-off-by: Argus Li <[email protected]>

* Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands

Signed-off-by: Argus Li <[email protected]>

* fix import

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@angle943 angle943 mentioned this pull request Jan 18, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angle943 angle943 angle943 requested changes

@ananzh ananzh ananzh approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative repeat-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Saved Queries] TESTID-125: Loading a Saved query with filters, time range , query
4 participants
@ArgusLi @ananzh @angle943 @LDrago27