Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [workspace]Fix/UI of assets table #9121

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6e851ff from #8519.

* fix/UI_of_assets_table

Signed-off-by: Qxisylolo <[email protected]>

* fix/the_UI_of_assets_table, add tests

Signed-off-by: Qxisylolo <[email protected]>

* use workspaceNameIdLookup

Signed-off-by: Qxisylolo <[email protected]>

* delete comment

Signed-off-by: Qxisylolo <[email protected]>

* use workspace column

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR #8519 created/updated

* use gear icon

Signed-off-by: Qxisylolo <[email protected]>

* use gear icon

Signed-off-by: Qxisylolo <[email protected]>

* new update

Signed-off-by: Qxisylolo <[email protected]>

* revert deleted line

Signed-off-by: Qxisylolo <[email protected]>

* correct import

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6e851ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (1050dee) to head (f386645).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...c/components/workspace_column/workspace_column.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #9121   +/-   ##
=======================================
  Coverage   60.87%   60.88%           
=======================================
  Files        3807     3807           
  Lines       91112    91124   +12     
  Branches    14375    14378    +3     
=======================================
+ Hits        55468    55479   +11     
- Misses      32116    32117    +1     
  Partials     3528     3528           
Flag Coverage Δ
Linux_1 29.02% <92.85%> (+0.01%) ⬆️
Linux_2 56.52% <ø> (ø)
Linux_3 37.84% <ø> (?)
Linux_4 30.02% <ø> (ø)
Windows_1 29.04% <92.85%> (+0.01%) ⬆️
Windows_2 56.48% <ø> (ø)
Windows_3 37.84% <ø> (ø)
Windows_4 30.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit a5f67f9 into 2.x Dec 27, 2024
69 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-8519-to-2.x branch December 27, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.19.0 valued-contributor workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants