Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Suggest] Fix Grammar Changes #9120

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Dec 24, 2024

Description

Redos changes made to the grammar meant for fixing bugs. Fixes those same original bugs through other means.

Also rewrites the 'redo and combine' functionality to be more robust.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

paulstn and others added 30 commits September 18, 2024 11:44
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
- wrote custom logic for rename command, to be clearer
- made sure value suggestions would only appear in strictly correct
  syntaxes
- changed nonexplicitly sorted suggestions to be lowest prio
- added sort preference to fields
- added verification of which fields values need to be found for
- made sure suggestions wouldnt appear for number literals and keyword
  IDS
- changed sorting of values to be extendible past 3 digits

Signed-off-by: Paul Sebastian <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 5.69620% with 149 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (89265b6) to head (e9fff9a).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...ntlr/opensearch_sql/opensearch_sql_autocomplete.ts 5.88% 31 Missing and 1 partial ⚠️
src/plugins/data/public/antlr/shared/utils.ts 13.88% 30 Missing and 1 partial ⚠️
...ntlr/opensearch_ppl/opensearch_ppl_autocomplete.ts 0.00% 29 Missing ⚠️
...ata/public/antlr/opensearch_sql/code_completion.ts 0.00% 28 Missing ⚠️
...ata/public/antlr/opensearch_ppl/code_completion.ts 0.00% 16 Missing ⚠️
...s/data/public/autocomplete/autocomplete_service.ts 0.00% 12 Missing ⚠️
...ugins/data/public/ui/query_editor/query_editor.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9120      +/-   ##
==========================================
- Coverage   60.87%   60.72%   -0.15%     
==========================================
  Files        3802     3808       +6     
  Lines       91060    91438     +378     
  Branches    14370    14455      +85     
==========================================
+ Hits        55435    55529      +94     
- Misses      32085    32355     +270     
- Partials     3540     3554      +14     
Flag Coverage Δ
Linux_1 28.88% <2.54%> (-0.14%) ⬇️
Linux_2 56.38% <ø> (-0.01%) ⬇️
Linux_3 37.84% <5.69%> (?)
Linux_4 28.88% <2.54%> (-0.12%) ⬇️
Windows_1 28.89% <2.54%> (-0.14%) ⬇️
Windows_2 56.34% <ø> (-0.01%) ⬇️
Windows_3 37.84% <5.69%> (-0.07%) ⬇️
Windows_4 28.88% <2.54%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant