Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard maps end point #893

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Oct 28, 2021

Signed-off-by: Junqiu Lei [email protected]

Description

Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.

https://discuss.opendistrocommunity.dev/t/status-of-kibana-maps/5106/36

Issues Resolved

#777

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@junqiu-lei junqiu-lei marked this pull request as draft October 28, 2021 23:45
@@ -41,7 +41,7 @@ export const configSchema = schema.object({
regionmap: regionmapSchema,
manifestServiceUrl: schema.string({ defaultValue: '' }),
opensearchManifestServiceUrl: schema.string({
defaultValue: 'https://maps.search-services.aws.a2z.com/v4/us-east-1/manifest',
defaultValue: 'https://maps.opensearch.org/manifest',
}),
emsFileApiUrl: schema.string({
defaultValue: 'https://vectors.maps.search-services.aws.a2z.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a vectors replacement yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update vectors and tiles url in ems client.

@kavilla
Copy link
Member

kavilla commented Oct 29, 2021

@junqiu-lei
Copy link
Member Author

should we replace this as well?

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/legacy/server/config/schema.js#L206

Yep, just updated in the latest commit.

@junqiu-lei
Copy link
Member Author

Test result on Jenkins:

image

@junqiu-lei junqiu-lei marked this pull request as ready for review November 1, 2021 05:43
@tmarkley tmarkley added the maps Issues or PRs related to the Maps Service label Nov 1, 2021
@tmarkley
Copy link
Contributor

tmarkley commented Nov 1, 2021

New functionality includes testing.

How are we testing these changes?

@kavilla
Copy link
Member

kavilla commented Nov 1, 2021

Screen Shot 2021-11-01 at 10 41 27 AM

Smoke test looking good to me.

@kavilla
Copy link
Member

kavilla commented Nov 1, 2021

@junqiuamz could you also squash your commits and include some of the information you have in the PR. I think it is really insightful on why we updated it.

@kavilla
Copy link
Member

kavilla commented Nov 1, 2021

Thanks for doing this. However, I think this bit of code looks weird now: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/maps_legacy/public/map/opensearch_dashboards_map.js#L614, where logically thinking, we should no longer care about this in open source realm. Tbh, it was my fault that this got into the code in the first place but it really sticks out like a sore thumb if we change the default values: should we address this as well: #362? EDIT: This isn't a blocker.

Also, do we plan on having documentation on how the OpenSearch Maps Service work? Proposal: a blog?

@kavilla kavilla linked an issue Nov 1, 2021 that may be closed by this pull request
@junqiu-lei
Copy link
Member Author

junqiu-lei commented Nov 1, 2021

New functionality includes testing.

How are we testing these changes?

We got test on querying end points, and test with dashboard locally like Kawika's Smoke test

@junqiu-lei
Copy link
Member Author

@junqiuamz could you also squash your commits and include some of the information you have in the PR. I think it is really insightful on why we updated it.

Np, will update

@vamshin
Copy link
Member

vamshin commented Nov 1, 2021

Also, do we plan on having documentation on how the OpenSearch Maps Service work? Proposal: a blog?

@kavilla We are working on mentioning about this new end point part of release. Thanks

Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.

opensearch-project#777

Signed-off-by: Junqiu Lei <[email protected]>
@tmarkley
Copy link
Contributor

tmarkley commented Nov 1, 2021

New functionality includes testing.

How are we testing these changes?

We got test on querying end points, and test with dashboard locally like Kawika's Smoke test

Can we add any automated tests here?

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests will be in a future PR

@kavilla kavilla merged commit cde8a78 into opensearch-project:main Nov 1, 2021
junqiu-lei added a commit to junqiu-lei/OpenSearch-Dashboards that referenced this pull request Nov 1, 2021
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.

opensearch-project#777

Signed-off-by: Junqiu Lei <[email protected]>
kavilla pushed a commit that referenced this pull request Nov 1, 2021
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.

#777

Signed-off-by: Junqiu Lei <[email protected]>
seanneumann pushed a commit that referenced this pull request Nov 2, 2021
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.

#777

Signed-off-by: Junqiu Lei <[email protected]>
@tmarkley tmarkley mentioned this pull request Dec 14, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maps Issues or PRs related to the Maps Service v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mapping service is not accessible from India
5 participants