-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard maps end point #893
Conversation
src/plugins/maps_legacy/config.ts
Outdated
@@ -41,7 +41,7 @@ export const configSchema = schema.object({ | |||
regionmap: regionmapSchema, | |||
manifestServiceUrl: schema.string({ defaultValue: '' }), | |||
opensearchManifestServiceUrl: schema.string({ | |||
defaultValue: 'https://maps.search-services.aws.a2z.com/v4/us-east-1/manifest', | |||
defaultValue: 'https://maps.opensearch.org/manifest', | |||
}), | |||
emsFileApiUrl: schema.string({ | |||
defaultValue: 'https://vectors.maps.search-services.aws.a2z.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a vectors replacement yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update vectors and tiles url in ems client.
should we replace this as well? |
Yep, just updated in the latest commit. |
How are we testing these changes? |
@junqiuamz could you also squash your commits and include some of the information you have in the PR. I think it is really insightful on why we updated it. |
Also, do we plan on having documentation on how the OpenSearch Maps Service work? Proposal: a blog? |
We got test on querying end points, and test with dashboard locally like Kawika's Smoke test |
Np, will update |
@kavilla We are working on mentioning about this new end point part of release. Thanks |
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one. opensearch-project#777 Signed-off-by: Junqiu Lei <[email protected]>
Can we add any automated tests here? |
bd1bb10
to
273159a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests will be in a future PR
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one. opensearch-project#777 Signed-off-by: Junqiu Lei <[email protected]>
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one. #777 Signed-off-by: Junqiu Lei <[email protected]>
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one. #777 Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei [email protected]
Description
Currently the maps end point can't be accessed from India and China, we are going to update maps end point to the new one "maps.opensearch.org" for OpenSearch community users, which will solve the pain for opensource users from some region can't access to the existing one.
https://discuss.opendistrocommunity.dev/t/status-of-kibana-maps/5106/36
Issues Resolved
#777
Check List