Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]upgrade actions/upload-artifact to v4 #8855

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Nov 13, 2024

Description

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024, upgrade it to v4.

Issues Resolved

#8823

Screenshot

Testing the changes

Changelog

  • fix: upgrade actions/upload-artifact to v4

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (ab4e6e8) to head (7438bbb).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8855      +/-   ##
==========================================
+ Coverage   60.85%   60.87%   +0.01%     
==========================================
  Files        3802     3802              
  Lines       91059    91059              
  Branches    14376    14376              
==========================================
+ Hits        55417    55431      +14     
+ Misses      32103    32090      -13     
+ Partials     3539     3538       -1     
Flag Coverage Δ
Linux_1 29.01% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.87% <ø> (+<0.01%) ⬆️
Linux_4 29.00% <ø> (ø)
Windows_1 29.04% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.87% <ø> (ø)
Windows_4 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Hailong-am Hailong-am changed the title upgrade actions/upload-artifact to v4 [chroe]upgrade actions/upload-artifact to v4 Nov 13, 2024
@Hailong-am Hailong-am changed the title [chroe]upgrade actions/upload-artifact to v4 [chore]upgrade actions/upload-artifact to v4 Nov 13, 2024
@Hailong-am Hailong-am marked this pull request as ready for review November 13, 2024 05:47
@Hailong-am Hailong-am merged commit 608911e into opensearch-project:main Nov 19, 2024
68 of 69 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8855-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 608911e3fa8576cc8078e49807e46de9e30eda56
# Push it to GitHub
git push --set-upstream origin backport/backport-8855-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8855-to-2.x.

Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Nov 19, 2024
* upgrade actioins/upload-artifact to v4

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR opensearch-project#8855 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 608911e)
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Nov 20, 2024
* upgrade actioins/upload-artifact to v4

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR opensearch-project#8855 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8855-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 608911e3fa8576cc8078e49807e46de9e30eda56
# Push it to GitHub
git push --set-upstream origin backport/backport-8855-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8855-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants