Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update Observability Data Sources with Type and Redirection #8673

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5d74306 from #8492.

* add type to datasources description area

Signed-off-by: Paul Sebastian <[email protected]>

* complete merge

Signed-off-by: Paul Sebastian <[email protected]>

* keep imports

Signed-off-by: Paul Sebastian <[email protected]>

* update redirection to discover

Signed-off-by: Paul Sebastian <[email protected]>

* let only datasource redirection to explorer use plain discover

Signed-off-by: Paul Sebastian <[email protected]>

* Changeset file for PR #8492 created/updated

* update for case where flint is within default cluster

Signed-off-by: Paul Sebastian <[email protected]>

* rename helper functions

Signed-off-by: Paul Sebastian <[email protected]>

* fix tests

Signed-off-by: Paul Sebastian <[email protected]>

* disabled redir on query enhancements disabled

Signed-off-by: Paul Sebastian <[email protected]>

* shelter against rison encoding error

Signed-off-by: Paul Sebastian <[email protected]>

* try catch getting ui settings

Signed-off-by: Paul Sebastian <[email protected]>

* update tests

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5d74306)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.90%. Comparing base (bde23d9) to head (541c2cf).
Report is 12 commits behind head on 2.x.

Files with missing lines Patch % Lines
..._management/utils/associated_objects_tab_utils.tsx 70.00% 1 Missing and 2 partials ⚠️
...ted_object_management/associated_objects_table.tsx 60.00% 2 Missing ⚠️
...nts/acceleration_management/acceleration_table.tsx 75.00% 1 Missing ⚠️
...nnection_detail/direct_query_connection_detail.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8673   +/-   ##
=======================================
  Coverage   60.90%   60.90%           
=======================================
  Files        3787     3787           
  Lines       90341    90354   +13     
  Branches    14167    14171    +4     
=======================================
+ Hits        55024    55033    +9     
- Misses      31847    31851    +4     
  Partials     3470     3470           
Flag Coverage Δ
Linux_1 29.01% <14.28%> (-0.01%) ⬇️
Linux_2 56.53% <ø> (ø)
Linux_3 37.71% <77.41%> (+<0.01%) ⬆️
Linux_4 29.93% <14.28%> (-0.01%) ⬇️
Windows_1 29.02% <14.28%> (-0.01%) ⬇️
Windows_2 56.48% <ø> (ø)
Windows_3 37.71% <77.41%> (+<0.01%) ⬆️
Windows_4 29.93% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh merged commit 3b892e6 into 2.x Oct 24, 2024
68 of 70 checks passed
@github-actions github-actions bot deleted the backport/backport-8492-to-2.x branch October 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.18.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants