Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation]Refactor: flatten left nav in Analytics(all) use case #8466

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6677891 from #8332.

)

* feat: move the logic to construct navLinks in all use case to nav_group_service

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change category

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register search overview to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8332 created/updated

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: show icon in category to expand or collapse

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge fix/fit-finish

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish whole refactor

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: style update

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit tets

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8332 created/updated

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: i18n

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update style

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update style

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless scss

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change icon color to text and update the style a little bit

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update naming

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: warning

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comments

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6677891)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (51344bf) to head (c699a05).
Report is 118 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../core/public/chrome/nav_group/nav_group_service.ts 80.00% 1 Missing and 5 partials ⚠️
...public/chrome/ui/header/collapsible_nav_groups.tsx 55.55% 1 Missing and 3 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 60.00% 0 Missing and 2 partials ⚠️
.../chrome/ui/header/collapsible_nav_groups_label.tsx 86.66% 1 Missing and 1 partial ⚠️
.../public/components/feature_cards/feature_cards.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8466      +/-   ##
==========================================
- Coverage   61.04%   61.02%   -0.02%     
==========================================
  Files        3757     3758       +1     
  Lines       89299    89296       -3     
  Branches    13962    13958       -4     
==========================================
- Hits        54511    54492      -19     
- Misses      31403    31415      +12     
- Partials     3385     3389       +4     
Flag Coverage Δ
Linux_1 28.91% <1.42%> (-0.01%) ⬇️
Linux_2 56.41% <80.00%> (-0.06%) ⬇️
Linux_3 37.81% <1.42%> (-0.01%) ⬇️
Linux_4 30.06% <10.25%> (-0.02%) ⬇️
Windows_1 28.93% <1.42%> (-0.01%) ⬇️
Windows_2 56.37% <80.00%> (-0.06%) ⬇️
Windows_3 37.81% <1.42%> (-0.01%) ⬇️
Windows_4 30.06% <10.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 0ee71b2 into 2.x Oct 4, 2024
67 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-8332-to-2.x branch October 4, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset navigation v2.18.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants