Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]Refactor use case selector in workspace creation page #8444

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b5a379 from #8413.

* Refactor use case selector in workspace create

Signed-off-by: Lin Wang <[email protected]>

* Add gap for details panel title

Signed-off-by: Lin Wang <[email protected]>

* Update use case name and description

Signed-off-by: Lin Wang <[email protected]>

* Filter out hidden nav links

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #8413 created/updated

* Add test case for different feature details

Signed-off-by: Lin Wang <[email protected]>

* Change back to "Analytics"

Signed-off-by: Lin Wang <[email protected]>

* Add all features suffix for all use case

Signed-off-by: Lin Wang <[email protected]>

* Fix failed unit tests

Signed-off-by: Lin Wang <[email protected]>

* Filter out getting started links

Signed-off-by: Lin Wang <[email protected]>

* Renaming isFlyoutVisible to isUseCaseFlyoutVisible

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7b5a379)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (2037aa4) to head (ff3ae98).
Report is 9 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/plugins/workspace/public/utils.ts 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8444      +/-   ##
==========================================
- Coverage   61.02%   61.01%   -0.01%     
==========================================
  Files        3755     3756       +1     
  Lines       89206    89228      +22     
  Branches    13939    13947       +8     
==========================================
+ Hits        54439    54446       +7     
- Misses      31389    31400      +11     
- Partials     3378     3382       +4     
Flag Coverage Δ
Linux_1 28.91% <97.91%> (+0.02%) ⬆️
Linux_2 56.46% <ø> (ø)
Linux_3 37.79% <ø> (-0.01%) ⬇️
Linux_4 30.08% <ø> (ø)
Windows_1 28.92% <97.91%> (+0.02%) ⬆️
Windows_2 ?
Windows_3 37.80% <ø> (ø)
Windows_4 30.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit dea0458 into 2.x Oct 3, 2024
67 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-8413-to-2.x branch October 3, 2024 03:07
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…nsearch-project#8413) (opensearch-project#8444)

* Refactor use case selector in workspace create



* Add gap for details panel title



* Update use case name and description



* Filter out hidden nav links



* Changeset file for PR opensearch-project#8413 created/updated

* Add test case for different feature details



* Change back to "Analytics"



* Add all features suffix for all use case



* Fix failed unit tests



* Filter out getting started links



* Renaming isFlyoutVisible to isUseCaseFlyoutVisible



---------



(cherry picked from commit 7b5a379)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants