Compress the OuiSearchBar instances used on Advanced Settings and Saved Object Management pages #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8443 +/- ##
==========================================
- Coverage 60.94% 60.93% -0.01%
==========================================
Files 3759 3759
Lines 89329 89329
Branches 13973 13973
==========================================
- Hits 54438 54436 -2
- Misses 31494 31495 +1
- Partials 3397 3398 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
force-pushed
the
fix-searchbar-spacing
branch
from
ce56edf to
1b4a743
Compare
|
Can you update snapshot tests |
AMoo-Miki
force-pushed
the
fix-searchbar-spacing
branch
from
1b4a743 to
551eb24
Compare
|
Looks like src/plugins/advanced_settings/public/management_app/advanced_settings.test.tsx still needs to be updated |
AMoo-Miki
force-pushed
the
fix-searchbar-spacing
branch
from
551eb24 to
e39b28a
Compare
…ed Object Management pages Also: * Fix spacing of the search bar on Advanced Settings page Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
fix-searchbar-spacing
branch
from
e39b28a to
74362fa
Compare
virajsanghvi
approved these changes
Oct 3, 2024
huyaboo
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ed Object Management pages (#8443) Also: * Fix spacing of the search bar on Advanced Settings page Signed-off-by: Miki <[email protected]> (cherry picked from commit 6176b34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Oct 4, 2024
…ed Object Management pages (#8443) (#8474) Also: * Fix spacing of the search bar on Advanced Settings page (cherry picked from commit 6176b34) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compress the OuiSearchBar instances used on Advanced Settings and Saved Object Management pages
Also:
Note: An OUI update will be required before these kick in.
Screenshot
Saved Object Management
Advanced Settings
Changelog
Check List
yarn test:jestyarn test:jest_integration