Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Discover] Display Cache Time and Clear Cache Button #8421

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a7f3e9d from #8214.

* initial commit for cache time and clearing cache

Signed-off-by: Sean Li <[email protected]>

* Changeset file for PR #8214 created/updated

* updating UI to address some comments

Signed-off-by: Sean Li <[email protected]>

* addressing comments, adding tests

Signed-off-by: Sean Li <[email protected]>

* removing dynamic default message, following i18n best practice

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a7f3e9d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (027bdda) to head (917fc64).
Report is 9 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ta/public/ui/dataset_selector/dataset_explorer.tsx 0.00% 4 Missing ⚠️
...ry/query_string/dataset_service/dataset_service.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8421      +/-   ##
==========================================
- Coverage   61.01%   61.01%   -0.01%     
==========================================
  Files        3750     3750              
  Lines       89130    89139       +9     
  Branches    13922    13924       +2     
==========================================
+ Hits        54384    54386       +2     
- Misses      31371    31376       +5     
- Partials     3375     3377       +2     
Flag Coverage Δ
Linux_1 28.86% <0.00%> (-0.01%) ⬇️
Linux_2 56.46% <0.00%> (-0.01%) ⬇️
Linux_3 37.76% <44.44%> (?)
Linux_4 30.08% <0.00%> (-0.01%) ⬇️
Windows_1 28.87% <0.00%> (-0.01%) ⬇️
Windows_2 56.41% <0.00%> (-0.01%) ⬇️
Windows_3 37.76% <44.44%> (-0.01%) ⬇️
Windows_4 30.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 036496c into 2.x Oct 2, 2024
68 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8214-to-2.x branch October 2, 2024 07:59
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…ect#8214) (opensearch-project#8421)

* initial commit for cache time and clearing cache



* Changeset file for PR opensearch-project#8214 created/updated

* updating UI to address some comments



* addressing comments, adding tests



* removing dynamic default message, following i18n best practice



---------



(cherry picked from commit a7f3e9d)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset seasoned-contributor v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants