Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unprefixed i18n identifiers in visTypeVega plugin #8406

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix unprefixed i18n identifiers in visTypeVega plugin #8406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9fbc94
Fix unprefixed i18n identifiers in visTypeVega plugin
AMoo-Miki Sep 30, 2024
8646673
Changeset file for PR #8406 created/updated
opensearch-changeset-bot[bot] Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8406.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Fix unprefixed i18n identifiers in visTypeVega plugin ([#8406](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8406))
8 changes: 4 additions & 4 deletions src/plugins/vis_type_vega/public/data_model/search_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,21 +156,21 @@ export class SearchAPI {
private getPPLRawResponseInspectorStats(response: RawPPLStrategySearchResponse['rawResponse']) {
const stats: RequestStatistics = {};
stats.hitsTotal = {
label: i18n.translate('data.search.searchSource.hitsTotalLabel', {
label: i18n.translate('visTypeVega.search.searchSource.hitsTotalLabel', {
defaultMessage: 'Hits (total)',
}),
value: `${response.total}`,
description: i18n.translate('data.search.searchSource.hitsTotalDescription', {
description: i18n.translate('visTypeVega.search.searchSource.hitsTotalDescription', {
defaultMessage: 'The number of documents that match the query.',
}),
};

stats.hits = {
label: i18n.translate('data.search.searchSource.hitsLabel', {
label: i18n.translate('visTypeVega.search.searchSource.hitsLabel', {
defaultMessage: 'Hits',
}),
value: `${response.size}`,
description: i18n.translate('data.search.searchSource.hitsDescription', {
description: i18n.translate('visTypeVega.search.searchSource.hitsDescription', {
defaultMessage: 'The number of documents returned by the query.',
}),
};
Expand Down
Loading