Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for a bug with Chrome 129 when handling mask-image #8274

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Temporary fix for a bug with Chrome 129 when handling mask-image #8274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063aa44
Temporary fix for a bug with Chrome 129 when handling mask-image
AMoo-Miki Sep 20, 2024
d05b1eb
Changeset file for PR #8274 created/updated
opensearch-changeset-bot[bot] Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8274.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Add a temporary fix for a bug with Chrome 129 when handling mask-image ([#8274](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8274))
28 changes: 28 additions & 0 deletions src/core/public/styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,31 @@ $euiCollapsibleNavWidth: $euiSize * 20;
height: auto;
width: auto;
}

// Temporary fix for a bug with Chrome 129 when handling mask-image
// OUI provides the mask-image used in these which Chrome 129 fails to render correctly.
// It is not known if or when Chrome will fix this. Since almost all of these classes
// are applied to elements with scrollbars where their content contained, containing the
// paint is a safe solution.
// This can be achieved with various tricks like transform: translate?(0) or
// transform-style: preserve-3d but they add to the browsers workload; contain doesn't.
// ToDo: Remove these when most used versions of Chrome no longer suffer from the bug.
// From OUI: any ruleset containing mask-image
.eui-yScrollWithShadows,
.eui-xScrollWithShadows,
.euiYScrollWithShadows,
.euiDataGrid__controlScroll,
.euiDataGridColumnSelector__columnList,
.euiDataGridColumnSorting__fieldList,
.euiFlyoutBody .euiFlyoutBody__overflow,
.euiFlyoutBody .euiFlyoutBody__overflow.euiFlyoutBody__overflow--hasBanner,
.euiModalBody .euiModalBody__overflow,
.euiSelectableList__list,
// For OSD: consumers of eui?ScrollWithShadows
.osdQueryBar__textarea:not(:focus):not(:invalid),
.osdSavedQueryManagement__list,
.dscCanvas,
.vbConfig,
.vbSidenav__style {
contain: paint;
}
Loading