Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] [Look&Feel] Updated Discover No Results panel #8224

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5d1c21b from #7891.

* Empty Prompt changes

Signed-off-by: Dan Dong <[email protected]>

Update src/plugins/discover/public/application/components/no_results/no_results.tsx

Co-authored-by: Miki <[email protected]>
Signed-off-by: Dan Dong <[email protected]>

Updated Discover No Results panel

Signed-off-by: Dan Dong <[email protected]>

* Changeset file for PR #7891 created/updated

* Changes for Cypress tests

Signed-off-by: Dan Dong <[email protected]>

* Added localization

Signed-off-by: Dan Dong <[email protected]>

---------

Signed-off-by: Dan Dong <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5d1c21b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (66369eb) to head (8a7b324).
Report is 1 commits behind head on 2.17.

Additional details and impacted files
@@           Coverage Diff           @@
##             2.17    #8224   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files        3737     3737           
  Lines       88754    88749    -5     
  Branches    13804    13802    -2     
=======================================
  Hits        56746    56746           
+ Misses      31410    31405    -5     
  Partials      598      598           
Flag Coverage Δ
Linux_1 29.96% <ø> (+<0.01%) ⬆️
Linux_2 58.95% <ø> (ø)
Linux_3 40.27% <ø> (+<0.01%) ⬆️
Linux_4 31.32% <ø> (ø)
Windows_1 29.97% <ø> (+<0.01%) ⬆️
Windows_2 58.89% <ø> (ø)
Windows_3 40.27% <ø> (+<0.01%) ⬆️
Windows_4 31.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu merged commit 10bb541 into 2.17 Sep 18, 2024
68 of 70 checks passed
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.17.1 autocut Skip the changelog verification check on backports failed changeset look & feel Look and Feel Improvements seasoned-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants