[Workspace]Fix the UI of recent assets in the header #8156

Qxisylolo · 2024-09-12T06:57:43Z

Description

This pr fixes the UI issue of recent assets in the header

Screenshot

fix: Icons should be styled with single color Style = "Text"
fix: Add cog icon as trigger for preferences dropdown and remove preferences button from the bottom
fix: Add spacing between recent item name and workspace name

Changelog

fix: Fix the UI of recent assets in the header

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

ruanyl · 2024-09-18T06:35:54Z

src/core/public/chrome/ui/header/recent_items.tsx

      >
-        <EuiTitle size="xxs">
+        <EuiText size="m">


Should this be size="s" with h3?

Hi, thanks for spotting the issue. I update size='s' with h4 to set the font size to 16px, which can be seen in the attached picture, where in figma both the "Recent Title" and "Recent Workspace" share the same font size

codecov · 2024-09-18T06:42:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (66331eb) to head (0da4907).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8156      +/-   ##
==========================================
+ Coverage   60.90%   60.91%   +0.01%     
==========================================
  Files        3808     3808              
  Lines       91178    91178              
  Branches    14396    14396              
==========================================
+ Hits        55529    55541      +12     
+ Misses      32095    32083      -12     
  Partials     3554     3554

Flag	Coverage Δ
Linux_1	`28.99% <ø> (ø)`
Linux_2	`56.38% <ø> (ø)`
Linux_3	`38.01% <ø> (ø)`
Linux_4	`29.01% <ø> (ø)`
Windows_1	`29.02% <ø> (+0.01%)`	⬆️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`38.01% <ø> (ø)`
Windows_4	`29.01% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl

Looks good to me, let's remove the console.log

ruanyl · 2024-10-30T09:06:08Z

src/core/public/chrome/ui/header/recent_items.tsx

@@ -124,6 +123,9 @@ export const RecentItems = ({
  const navLinks = useObservable(navLinks$, []);
  const loadingCount = useObservable(loadingCount$, 0);

+  // eslint-disable-next-line
+  console.log('loadingCount', loadingCount);


Let's remove console.log

Thanks for the comment, all updated.

ruanyl · 2024-12-18T07:52:01Z

@Qxisylolo Approved, but you may need to resolve the conflicts

Signed-off-by: Qxisylolo <[email protected]>

Hailong-am · 2024-12-24T01:27:28Z

src/core/public/chrome/ui/header/recent_items.tsx

-            defaultMessage: 'Preferences',
-          })}
-        </EuiButtonEmpty>
+          iconType="managementApp"


Icon type changed to gear?

Yes, please check the issue tracker:

* resolve conflicts Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the_UI_of_recent_assets, delete comments Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the recent title size Signed-off-by: Qxisylolo <[email protected]> * fix/the_UI_of_recent_assets, use icon button Signed-off-by: Qxisylolo <[email protected]> * fix/the_UI_of_recent_assets, a small fix Signed-off-by: Qxisylolo <[email protected]> * remove comment Signed-off-by: Qxisylolo <[email protected]> * new resolve conflicts Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #8156 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b1113f4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ect#8156) * resolve conflicts Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the_UI_of_recent_assets, delete comments Signed-off-by: Qxisylolo <[email protected]> * fix/ fix the recent title size Signed-off-by: Qxisylolo <[email protected]> * fix/the_UI_of_recent_assets, use icon button Signed-off-by: Qxisylolo <[email protected]> * fix/the_UI_of_recent_assets, a small fix Signed-off-by: Qxisylolo <[email protected]> * remove comment Signed-off-by: Qxisylolo <[email protected]> * new resolve conflicts Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR opensearch-project#8156 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Federico Silva <[email protected]>

* resolve conflicts * fix/ fix the_UI_of_recent_assets, delete comments * fix/ fix the recent title size * fix/the_UI_of_recent_assets, use icon button * fix/the_UI_of_recent_assets, a small fix * remove comment * new resolve conflicts * Changeset file for PR #8156 created/updated --------- (cherry picked from commit b1113f4) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the valued-contributor label Sep 12, 2024

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Sep 12, 2024

Changeset file for PR opensearch-project#8156 created/updated

324fc82

Qxisylolo marked this pull request as ready for review September 12, 2024 07:27

kavilla added the workspace label Sep 12, 2024

ruanyl reviewed Sep 18, 2024

View reviewed changes

ruanyl added backport 2.x workspace labels Oct 29, 2024

ruanyl reviewed Oct 30, 2024

View reviewed changes

SuZhou-Joe added the v2.19.0 label Oct 30, 2024

Qxisylolo force-pushed the fix/the_UI_of_recent_assets branch from 6d6c552 to 2a26e67 Compare October 31, 2024 07:56

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 31, 2024

Changeset file for PR opensearch-project#8156 created/updated

32b7f2c

SuZhou-Joe previously approved these changes Nov 12, 2024

View reviewed changes

ruanyl previously approved these changes Dec 18, 2024

View reviewed changes

Qxisylolo added 6 commits December 23, 2024 13:08

resolve conflicts

f60bc02

Signed-off-by: Qxisylolo <[email protected]>

fix/ fix the_UI_of_recent_assets, delete comments

4bdc327

Signed-off-by: Qxisylolo <[email protected]>

fix/ fix the recent title size

bc8ca44

Signed-off-by: Qxisylolo <[email protected]>

fix/the_UI_of_recent_assets, use icon button

9222c24

Signed-off-by: Qxisylolo <[email protected]>

fix/the_UI_of_recent_assets, a small fix

75bdd38

Signed-off-by: Qxisylolo <[email protected]>

remove comment

c568819

Signed-off-by: Qxisylolo <[email protected]>

Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Dec 23, 2024

Changeset file for PR opensearch-project#8156 created/updated

5efeda8

Qxisylolo dismissed stale reviews from ruanyl and SuZhou-Joe via 19d62c1 December 23, 2024 05:18

Qxisylolo force-pushed the fix/the_UI_of_recent_assets branch 2 times, most recently from 13826cc to afde0b9 Compare December 23, 2024 05:39

new resolve conflicts

618c975

Signed-off-by: Qxisylolo <[email protected]>

Qxisylolo force-pushed the fix/the_UI_of_recent_assets branch from afde0b9 to 618c975 Compare December 23, 2024 05:42

Changeset file for PR opensearch-project#8156 created/updated

0da4907

ruanyl approved these changes Dec 23, 2024

View reviewed changes

Hailong-am approved these changes Dec 24, 2024

View reviewed changes

ruanyl merged commit b1113f4 into opensearch-project:main Dec 24, 2024
69 checks passed

opensearch-trigger-bot bot mentioned this pull request Dec 24, 2024

[Backport 2.x] [Workspace]Fix the UI of recent assets in the header #9115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace]Fix the UI of recent assets in the header #8156

[Workspace]Fix the UI of recent assets in the header #8156

Qxisylolo commented Sep 12, 2024 •

edited

Loading

ruanyl Sep 18, 2024

Qxisylolo Sep 18, 2024

codecov bot commented Sep 18, 2024 •

edited

Loading

ruanyl left a comment

ruanyl Oct 30, 2024

Qxisylolo Oct 31, 2024

ruanyl commented Dec 18, 2024

Hailong-am Dec 24, 2024

Qxisylolo Dec 24, 2024

[Workspace]Fix the UI of recent assets in the header #8156

[Workspace]Fix the UI of recent assets in the header #8156

Conversation

Qxisylolo commented Sep 12, 2024 • edited Loading

Description

Screenshot

Changelog

Check List

ruanyl Sep 18, 2024

Choose a reason for hiding this comment

Qxisylolo Sep 18, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 18, 2024 • edited Loading

Codecov Report

ruanyl left a comment

Choose a reason for hiding this comment

ruanyl Oct 30, 2024

Choose a reason for hiding this comment

Qxisylolo Oct 31, 2024

Choose a reason for hiding this comment

ruanyl commented Dec 18, 2024

Hailong-am Dec 24, 2024

Choose a reason for hiding this comment

Qxisylolo Dec 24, 2024

Choose a reason for hiding this comment

Qxisylolo commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 18, 2024 •

edited

Loading