Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][Backport 2.x][Workspace]Redirect to use case landing page after workspace create #7970

Closed

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 3, 2024

Description

This PR is for backport #7933 to 2.x branch.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

…pensearch-project#7933)

* Redirect to use case landing page after workspace create

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR opensearch-project#7933 created/updated

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
@wanglam wanglam force-pushed the backport/backport-7933-to-2.x branch from 7450e2e to ac659a9 Compare September 3, 2024 09:04
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (f7a168d) to head (d053a22).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...components/workspace_creator/workspace_creator.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7970   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files        3686     3686           
  Lines       87139    87142    +3     
  Branches    13387    13388    +1     
=======================================
+ Hits        53275    53277    +2     
  Misses      30632    30632           
- Partials     3232     3233    +1     
Flag Coverage Δ
Linux_1 28.80% <66.66%> (+<0.01%) ⬆️
Linux_2 56.36% <ø> (ø)
Linux_4 29.67% <ø> (ø)
Windows_1 28.82% <66.66%> (+<0.01%) ⬆️
Windows_2 56.31% <ø> (ø)
Windows_3 37.98% <ø> (ø)
Windows_4 29.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl
Copy link
Member

ruanyl commented Sep 4, 2024

@wanglam This PR is in draft state, is it ready for review?

@wanglam wanglam marked this pull request as ready for review September 4, 2024 06:00
@wanglam wanglam requested a review from ananzh as a code owner September 4, 2024 06:00
@wanglam
Copy link
Contributor Author

wanglam commented Sep 4, 2024

@ruanyl I think this PR is ready for review. Feel free to help me review it. Thank you.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Sep 4, 2024
@wanglam
Copy link
Contributor Author

wanglam commented Sep 4, 2024

This PR can be automatic backport now. Already created a PR at #7933 . @ruanyl Could you help me review it? I will close current PR.

@wanglam wanglam closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants