Correct the mime-type of exported CSVs #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 2e49297 |
|
|
|
Thanks for doing this! NIT: Everything looks great! But can you actually add more to the git description to have the description you have in the PR. It will helpful for people when using git tools if it had more information. |
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv. Issues Resolved opensearch-project#640 Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
fix-csv-export-mime
branch
from
2e49297 to
a2de1f9
Compare
|
✅ DCO Check Passed a2de1f9 |
tmarkley
pushed a commit
to tmarkley/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2021
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv. Issues Resolved opensearch-project#640 Signed-off-by: Miki <[email protected]>
1 task
tmarkley
pushed a commit
that referenced
this pull request
Sep 24, 2021
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv. Issues Resolved #640 Signed-off-by: Miki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miki [email protected]
Description
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to
text/plainin a few places. This commit changes the mime-type to betext/csv.Issues Resolved
#640
Check List