Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TESTING.md #770

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Update TESTING.md #770

merged 1 commit into from
Sep 8, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Sep 8, 2021

Signed-off-by: Bishoy Boktor [email protected]

Description

Fix TESTING.md wording

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Update TESTING.md
f5a246c 
Signed-off-by: Bishoy Boktor <[email protected]>
@kavilla
Copy link
Member

kavilla commented Sep 8, 2021

😅

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f5a246c

tmarkley
tmarkley approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@boktorbb boktorbb merged commit 0d07a9a into opensearch-project:main Sep 8, 2021
@tmarkley tmarkley added docs Improvements or additions to documentation backport pending labels Sep 9, 2021
boktorbb added a commit to boktorbb/OpenSearch-Dashboards that referenced this pull request Sep 9, 2021
@boktorbb
Update TESTING.md (opensearch-project#770)
279614b 
Signed-off-by: Bishoy Boktor <[email protected]>
boktorbb added a commit to boktorbb/OpenSearch-Dashboards that referenced this pull request Sep 9, 2021
@boktorbb
Update TESTING.md (opensearch-project#770)
41d1fac 
Signed-off-by: Bishoy Boktor <[email protected]>
@tmarkley tmarkley added the v1.1.0 label Sep 9, 2021
This was referenced Sep 9, 2021
Merged
Merged
tmarkley pushed a commit that referenced this pull request Sep 9, 2021
@boktorbb
Update TESTING.md (#770) (#776)
7044636 
Signed-off-by: Bishoy Boktor <[email protected]>
tmarkley pushed a commit that referenced this pull request Sep 9, 2021
@boktorbb
Update TESTING.md (#770) (#775)
d753872 
Signed-off-by: Bishoy Boktor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@kavilla kavilla kavilla approved these changes

@tmarkley tmarkley tmarkley approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boktorbb @kavilla @opensearch-ci-bot @tmarkley @ananzh