[Workspace] update workspace-list-card and home-list-card #7547

Qxisylolo · 2024-07-29T03:46:03Z

Description

Here, I updated the workspace-list-card and home-list-card by adjusting the view-all button position and fixing the overflow issue.

Issues Resolved

adjusting the view-all button position and reorganize the content into Flex
fixing the issue that caused overflow when resizing the window or increasing content.

Screenshot

appearance：before

appearance：after

before-when resizing

after-when resizing

Changelog

fix: [Workspace] updating workspace-list-card and home-list-card

github-actions · 2024-07-29T03:46:32Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2024-07-29T03:52:15Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2024-07-29T03:54:08Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2024-07-29T03:59:56Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2024-07-29T04:02:44Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2024-07-29T04:07:58Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "- fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

SuZhou-Joe · 2024-07-29T06:41:38Z

@Qxisylolo Thanks for that, could you please add CHANGELOG entry for this PR?

src/plugins/home/public/application/components/home_list_card.tsx

SuZhou-Joe · 2024-07-29T06:44:11Z

src/plugins/home/public/application/components/home_list_card.tsx

+          </EuiTitle>
+        }
+        description={
+          config.list.length > 0 && (


Do we need any empty state for empty list?

I'm not sure. For now the config is set manually and we don't need empty list.

src/plugins/home/public/application/components/home_list_card.tsx

codecov · 2024-07-30T06:39:11Z

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (61d5c49) to head (f98b428).
Report is 229 commits behind head on main.

Files with missing lines	Patch %	Lines
...ic/components/service_card/workspace_list_card.tsx	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7547      +/-   ##
==========================================
+ Coverage   63.64%   63.66%   +0.01%     
==========================================
  Files        3634     3634              
  Lines       80099    80099              
  Branches    12682    12682              
==========================================
+ Hits        50977    50993      +16     
+ Misses      26015    26001      -14     
+ Partials     3107     3105       -2

Flag	Coverage Δ
Linux_1	`30.56% <60.00%> (+<0.01%)`	⬆️
Linux_2	`55.58% <ø> (ø)`
Linux_3	`40.58% <0.00%> (-0.01%)`	⬇️
Linux_4	`31.33% <100.00%> (+<0.01%)`	⬆️
Windows_1	`30.60% <60.00%> (+0.02%)`	⬆️
Windows_2	`55.53% <ø> (ø)`
Windows_3	`40.58% <0.00%> (ø)`
Windows_4	`31.33% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yang <[email protected]>

Signed-off-by: Qxisylolo <[email protected]>

…and write new testes Signed-off-by: Qxisylolo <[email protected]>

ruanyl

Thank you, great work!

ruanyl · 2024-08-02T03:13:50Z

src/plugins/workspace/public/components/service_card/workspace_list_card.tsx

-          </EuiToolTip>
+        <EuiSpacer />
+        <EuiFlexItem grow={true}>
+          {workspaceList && workspaceList.length === 0 ? (


This seems is existing code, but would be nice to change it in this way, as empty state should be displayed if workspaceList is undefined.

Suggested change

{workspaceList && workspaceList.length === 0 ? (

{!workspaceList || workspaceList.length === 0 ? (

Okok, Thanks for your comments~

* update workspace-list-card and home-list-card Signed-off-by: Yang <[email protected]> * new update home_list_card and workspace_list_card,solve some errors Signed-off-by: Qxisylolo <[email protected]> * new update home_list_card and workspace_list_card,solve some errors Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #7547 created/updated * new update home_list_card and workspace_list_card,solve some errors Signed-off-by: Qxisylolo <[email protected]> * new update home_list_card and workspace_list_card,solve some errors, and write new testes Signed-off-by: Qxisylolo <[email protected]> * new update home_list_card and workspace_list_card,solve some errors, and write new testes Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Yang <[email protected]> Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: Yang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 14c71c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) * update workspace-list-card and home-list-card * new update home_list_card and workspace_list_card,solve some errors * new update home_list_card and workspace_list_card,solve some errors * Changeset file for PR #7547 created/updated * new update home_list_card and workspace_list_card,solve some errors * new update home_list_card and workspace_list_card,solve some errors, and write new testes * new update home_list_card and workspace_list_card,solve some errors, and write new testes --------- (cherry picked from commit 14c71c7) Signed-off-by: Yang <[email protected]> Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the first-time-contributor label Jul 29, 2024

github-actions bot added the failed changeset label Jul 29, 2024

SuZhou-Joe reviewed Jul 29, 2024

View reviewed changes

src/plugins/home/public/application/components/home_list_card.tsx Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Jul 29, 2024

View reviewed changes

src/plugins/home/public/application/components/home_list_card.tsx Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Jul 29, 2024

View reviewed changes

src/plugins/home/public/application/components/home_list_card.tsx Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Jul 29, 2024

View reviewed changes

src/plugins/home/public/application/components/home_list_card.tsx Outdated Show resolved Hide resolved

Qxisylolo requested a review from joshuali925 as a code owner July 30, 2024 06:12

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Jul 30, 2024

Changeset file for PR opensearch-project#7547 created/updated

bc0f0c1

github-actions bot removed the failed changeset label Jul 30, 2024

ruanyl added the v2.17.0 label Jul 30, 2024

opensearch-project deleted a comment from github-actions bot Jul 31, 2024

Yang and others added 7 commits August 1, 2024 11:15

update workspace-list-card and home-list-card

6808440

Signed-off-by: Yang <[email protected]>

new update home_list_card and workspace_list_card,solve some errors

d5e1f17

Signed-off-by: Qxisylolo <[email protected]>

new update home_list_card and workspace_list_card,solve some errors

c7e4b8b

Signed-off-by: Qxisylolo <[email protected]>

Changeset file for PR opensearch-project#7547 created/updated

d5a6e0b

new update home_list_card and workspace_list_card,solve some errors

f0f6630

Signed-off-by: Qxisylolo <[email protected]>

new update home_list_card and workspace_list_card,solve some errors, …

3573050

…and write new testes Signed-off-by: Qxisylolo <[email protected]>

new update home_list_card and workspace_list_card,solve some errors, …

f98b428

…and write new testes Signed-off-by: Qxisylolo <[email protected]>

Qxisylolo force-pushed the dev branch from d0aa098 to f98b428 Compare August 1, 2024 03:15

ruanyl approved these changes Aug 2, 2024

View reviewed changes

SuZhou-Joe added the workspace label Aug 2, 2024

SuZhou-Joe approved these changes Aug 2, 2024

View reviewed changes

SuZhou-Joe merged commit 14c71c7 into opensearch-project:main Aug 2, 2024
69 checks passed

SuZhou-Joe added the backport 2.x label Aug 8, 2024

opensearch-trigger-bot bot mentioned this pull request Aug 8, 2024

[Backport 2.x] [Workspace] update workspace-list-card and home-list-card #7650

Merged

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] update workspace-list-card and home-list-card #7547

[Workspace] update workspace-list-card and home-list-card #7547

Qxisylolo commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

SuZhou-Joe commented Jul 29, 2024

SuZhou-Joe Jul 29, 2024

Qxisylolo Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

ruanyl left a comment

ruanyl Aug 2, 2024

Qxisylolo Aug 13, 2024

	{workspaceList && workspaceList.length === 0 ? (
	{!workspaceList \|\| workspaceList.length === 0 ? (

[Workspace] update workspace-list-card and home-list-card #7547

[Workspace] update workspace-list-card and home-list-card #7547

Conversation

Qxisylolo commented Jul 29, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Changelog

github-actions bot commented Jul 29, 2024

❌ Changelog Entry Missing Hyphen

github-actions bot commented Jul 29, 2024

❌ Changelog Entry Missing Hyphen

github-actions bot commented Jul 29, 2024

❌ Changelog Entry Missing Hyphen

github-actions bot commented Jul 29, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jul 29, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jul 29, 2024

❌ Invalid Prefix For Manual Changeset Creation

SuZhou-Joe commented Jul 29, 2024

SuZhou-Joe Jul 29, 2024

Choose a reason for hiding this comment

Qxisylolo Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

ruanyl left a comment

Choose a reason for hiding this comment

ruanyl Aug 2, 2024

Choose a reason for hiding this comment

Qxisylolo Aug 13, 2024

Choose a reason for hiding this comment

Qxisylolo commented Jul 29, 2024 •

edited

Loading

Qxisylolo Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading