Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for canvas for query enhancement #7537

Closed
wants to merge 2 commits into from

Conversation

abbyhu2000
Copy link
Member

Description

Add styling for canvas for query enhancement.

Issues Resolved

Screenshot

Screen.Recording.2024-07-26.at.5.55.23.PM.mov

Testing the changes

Changelog

  • feat: Add styling for canvas for query enhancement

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <[email protected]>
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.66%. Comparing base (3168283) to head (e640eee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7537   +/-   ##
=======================================
  Coverage   63.65%   63.66%           
=======================================
  Files        3629     3629           
  Lines       79499    79499           
  Branches    12597    12597           
=======================================
+ Hits        50605    50612    +7     
+ Misses      25826    25822    -4     
+ Partials     3068     3065    -3     
Flag Coverage Δ
Linux_1 30.76% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.24% <ø> (+<0.01%) ⬆️
Linux_4 31.57% <ø> (ø)
Windows_1 30.78% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.25% <ø> (ø)
Windows_4 31.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! do we even need the is enhancements enabled feature? im willing to bet people just want this regardless

@kavilla kavilla linked an issue Jul 27, 2024 that may be closed by this pull request
@ashwin-pc
Copy link
Member

Ive incorporated these changes in #7546 since changes here are affected by the querybar changes as well.

@abbyhu2000
Copy link
Member Author

Close this since #7546 is merged.

@abbyhu2000 abbyhu2000 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover-Next][UI] Date histogram can be collapsed
3 participants