-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI #7395
Merged
ruanyl
merged 2 commits into
opensearch-project:2.x
from
yubonluo:backport/2.x-restrict-datasource-ui
Jul 23, 2024
Merged
[Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI #7395
ruanyl
merged 2 commits into
opensearch-project:2.x
from
yubonluo:backport/2.x-restrict-datasource-ui
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce on the DSM UI (opensearch-project#7303) Signed-off-by: yubonluo <[email protected]>
… the DSM UI Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
July 23, 2024 07:11
github-actions
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Jul 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7395 +/- ##
=======================================
Coverage 67.82% 67.83%
=======================================
Files 3521 3521
Lines 69792 69794 +2
Branches 11379 11380 +1
=======================================
+ Hits 47336 47344 +8
+ Misses 19662 19658 -4
+ Partials 2794 2792 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 23, 2024
ruanyl
approved these changes
Jul 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
… the DSM UI (#7395) * Revert [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI (#7303) Signed-off-by: yubonluo <[email protected]> * [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 14071ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 23, 2024
… the DSM UI (#7395) (#7398) * Revert [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI (#7303) * [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI --------- (cherry picked from commit 14071ff) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.16
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
v2.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport #7214
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration